Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8307068: store a JavaThread* in the java.lang.Thread object after the JavaThread* is added to the main ThreadsList #1587

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jul 17, 2023

I backport this for parity with 17.0.9-oracle.

I had to resolve almost all of this change.
One of the reason is that JavaThread is in thread.cpp in 17,
but in a file of it's own in head.
All differences should be in the context, though.
The code could be applied unchanged.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8307068: store a JavaThread* in the java.lang.Thread object after the JavaThread* is added to the main ThreadsList (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1587/head:pull/1587
$ git checkout pull/1587

Update a local copy of the PR:
$ git checkout pull/1587
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1587/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1587

View PR using the GUI difftool:
$ git pr show -t 1587

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1587.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 17, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ceca198ef21b9003492b456d87180d2f48774f73 8307068: store a JavaThread* in the java.lang.Thread object after the JavaThread* is added to the main ThreadsList Jul 17, 2023
@openjdk
Copy link

openjdk bot commented Jul 17, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jul 17, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 17, 2023

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Jul 17, 2023

GHA failures:
Known risc-v issue.

@openjdk
Copy link

openjdk bot commented Jul 17, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307068: store a JavaThread* in the java.lang.Thread object after the JavaThread* is added to the main ThreadsList

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 17, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Jul 19, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jul 19, 2023

Going to push as commit 86e8887.
Since your change was applied there have been 19 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 19, 2023
@openjdk openjdk bot closed this Jul 19, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 19, 2023
@openjdk
Copy link

openjdk bot commented Jul 19, 2023

@GoeLin Pushed as commit 86e8887.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8307068 branch July 19, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants