Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8289745: JfrStructCopyFailed uses heap words instead of bytes for object sizes #1592

Conversation

schmelter-sap
Copy link
Contributor

@schmelter-sap schmelter-sap commented Jul 18, 2023

Hi all,

This pull request contains a backport of commit 7f0e9bd6 from the openjdk/jdk repository.

The commit being backported was authored by Ralf Schmelter on 12 Jul 2022 and was reviewed by Markus Grönlund and Thomas Stuefe.

It just fixes the metadata of an JFR event.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8289745 needs maintainer approval

Issue

  • JDK-8289745: JfrStructCopyFailed uses heap words instead of bytes for object sizes (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1592/head:pull/1592
$ git checkout pull/1592

Update a local copy of the PR:
$ git checkout pull/1592
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1592/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1592

View PR using the GUI difftool:
$ git pr show -t 1592

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1592.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 18, 2023

👋 Welcome back rschmelter! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 18, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 18, 2023

Webrevs

@phohensee
Copy link
Member

phohensee commented Jul 18, 2023

This PR isn't tagged as a backport. Please change the title to "Backport 7f0e9bd632198c7fd34d27b85ca51ea0e2442e4d". The bot should recognize it.

Other than that, the backport looks clean.

@schmelter-sap schmelter-sap changed the title 8289745: JfrStructCopyFailed uses heap words instead of bytes for object sizes Backport 7f0e9bd632198c7fd34d27b85ca51ea0e2442e4d Jul 19, 2023
@openjdk openjdk bot changed the title Backport 7f0e9bd632198c7fd34d27b85ca51ea0e2442e4d 8289745: JfrStructCopyFailed uses heap words instead of bytes for object sizes Jul 19, 2023
@openjdk
Copy link

openjdk bot commented Jul 19, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 19, 2023

@schmelter-sap This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289745: JfrStructCopyFailed uses heap words instead of bytes for object sizes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 228 new commits pushed to the master branch:

  • 4ebd8b3: 8311514: Incorrect regex in TestMetaSpaceLog.java
  • ac2d89b: 8311813: C1: Uninitialized PhiResolver::_loop field
  • 05964ff: 8315863: [GHA] Update checkout action to use v4
  • 875d24b: Merge
  • a831b7a: 8312555: Ideographic characters aren't stretched by AffineTransform.scale(2, 1)
  • a06047a: 8168469: Memory leak in JceSecurity
  • 1a68e52: 8314679: SA fails to properly attach to JVM after having just detached from a different JVM
  • 7588666: 8313657: com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors
  • a3e8026: 8294427: Check boxes and radio buttons have rendering issues on Windows in High DPI env
  • d2045f9: 8265586: [windows] last button is not shown in AWT Frame with BorderLayout and MenuBar set.
  • ... and 218 more: https://git.openjdk.org/jdk17u-dev/compare/17744caa87ac313e924deb92af37c491cf7c97bc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 19, 2023
@phohensee
Copy link
Member

Looks good, please tag the JBS issue.

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 16, 2023

@schmelter-sap This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@openjdk
Copy link

openjdk bot commented Sep 21, 2023

⚠️ @schmelter-sap This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@schmelter-sap
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 28, 2023

Going to push as commit 0ce7d86.
Since your change was applied there have been 275 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 28, 2023
@openjdk openjdk bot closed this Sep 28, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 28, 2023
@openjdk
Copy link

openjdk bot commented Sep 28, 2023

@schmelter-sap Pushed as commit 0ce7d86.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants