Skip to content

8293166: jdk/jfr/jvm/TestDumpOnCrash.java fails on Linux ppc64le and Linux aarch64 #1594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

schmelter-sap
Copy link
Contributor

@schmelter-sap schmelter-sap commented Jul 18, 2023

Hi all,

This pull request contains a backport of commit 5551cb66 from the openjdk/jdk repository.

The commit being backported was authored by Ralf Schmelter on 22 Nov 2022 and was reviewed by Matthias Baesken and Thomas Stuefe.

It just fixes the metadata of an JFR event.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8293166: jdk/jfr/jvm/TestDumpOnCrash.java fails on Linux ppc64le and Linux aarch64 (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1594/head:pull/1594
$ git checkout pull/1594

Update a local copy of the PR:
$ git checkout pull/1594
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1594/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1594

View PR using the GUI difftool:
$ git pr show -t 1594

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1594.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 18, 2023

👋 Welcome back rschmelter! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 18, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 18, 2023

Webrevs

@schmelter-sap schmelter-sap changed the title 8293166: jdk/jfr/jvm/TestDumpOnCrash.java fails on Linux ppc64le and Linux aarch64 Backport 5551cb66ba58cadce7291a95c5af662ade2cb7b8 Jul 19, 2023
@openjdk openjdk bot changed the title Backport 5551cb66ba58cadce7291a95c5af662ade2cb7b8 8293166: jdk/jfr/jvm/TestDumpOnCrash.java fails on Linux ppc64le and Linux aarch64 Jul 19, 2023
@openjdk
Copy link

openjdk bot commented Jul 19, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Jul 19, 2023
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk
Copy link

openjdk bot commented Jul 20, 2023

@schmelter-sap This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293166: jdk/jfr/jvm/TestDumpOnCrash.java fails on Linux ppc64le and Linux aarch64

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

  • b40b1ca: 8295894: Remove SECOM certificate that is expiring in September 2023
  • 901e879: 8312029: Add CriticalNative tests to ProblemList for 8312028
  • fade19e: 8308803: Improve java/util/UUID/UUIDTest.java
  • 4b8c6b8: 8302736: Major performance regression in Math.log on aarch64
  • b5f27f9: 8307653: Adjust delay time and gc log argument in TestAbortOnVMOperationTimeout
  • b640436: 8277353: java/security/MessageDigest/ThreadSafetyTest.java test times out
  • a19156d: 8305766: ProblemList runtime/CompressedOops/CompressedClassPointers.java
  • 86e8887: 8307068: store a JavaThread* in the java.lang.Thread object after the JavaThread* is added to the main ThreadsList
  • 494cf45: 8307067: remove broken EnableThreadSMRExtraValidityChecks option
  • d98ac18: Merge
  • ... and 16 more: https://git.openjdk.org/jdk17u-dev/compare/d79c2ef1eebe06e6f5b760dbb01fca3b47995ca0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 20, 2023
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 17, 2023

@schmelter-sap This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@schmelter-sap
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 18, 2023

Going to push as commit 4dca60e.
Since your change was applied there have been 82 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 18, 2023
@openjdk openjdk bot closed this Aug 18, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 18, 2023
@openjdk
Copy link

openjdk bot commented Aug 18, 2023

@schmelter-sap Pushed as commit 4dca60e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants