Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274562: (fs) UserDefinedFileAttributeView doesn't correctly determine if supported when using OverlayFS #160

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Feb 14, 2022

A tiny bugfix for 17.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8274562: (fs) UserDefinedFileAttributeView doesn't correctly determine if supported when using OverlayFS

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/160/head:pull/160
$ git checkout pull/160

Update a local copy of the PR:
$ git checkout pull/160
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/160/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 160

View PR using the GUI difftool:
$ git pr show -t 160

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/160.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 14, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3d7671b65e8491f3b1fcac8b96401401f783c9f4 8274562: (fs) UserDefinedFileAttributeView doesn't correctly determine if supported when using OverlayFS Feb 14, 2022
@openjdk
Copy link

openjdk bot commented Feb 14, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 14, 2022

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274562: (fs) UserDefinedFileAttributeView doesn't correctly determine if supported when using OverlayFS

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Feb 14, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 14, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Feb 15, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Feb 15, 2022

Going to push as commit 2011c35.
Since your change was applied there have been 4 commits pushed to the master branch:

  • ab3dd20: 8273655: content-types.properties files are missing some common types
  • a7010a2: 8279385: [test] Adjust sun/security/pkcs12/KeytoolOpensslInteropTest.java after 8278344
  • 7833c7d: 8280373: Update Xalan serializer / SystemIDResolver to align with JDK-8270492
  • 8207e69: 8272541: Incorrect overflow test in Toom-Cook branch of BigInteger multiplication

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Feb 15, 2022
@openjdk openjdk bot closed this Feb 15, 2022
@openjdk openjdk bot removed ready rfr labels Feb 15, 2022
@openjdk
Copy link

openjdk bot commented Feb 15, 2022

@GoeLin Pushed as commit 2011c35.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant