8301269: Update Commons BCEL to Version 6.7.0

[GoeLin]

One of the required updates of external libs.
I had to resolve Const.java and ConstantDynamic.java because "8294618: Update openjdk.java.net => openjdk.org" is not in 17.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8301269: Update Commons BCEL to Version 6.7.0 (Enhancement - P4)

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer) ⚠️ Review applies to 2dab1c85

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1610/head:pull/1610
$ git checkout pull/1610

Update a local copy of the PR:
$ git checkout pull/1610
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1610/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1610

View PR using the GUI difftool:
$ git pr show -t 1610

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1610.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[openjdk]

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full - Incremental (8f5383a5)
• 00: Full (2dab1c85)

[TheRealMDoerr]

The comment format change https://github.com/openjdk/jdk17u-dev/blame/2dab1c859a51f4eddc88ff96c1f3137f670284d8/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantDynamic.java#L80C6-L80C6 is missing. (See https://github.com/openjdk/jdk/blame/6a44120a16d0f06b4ed9f0ebf6b0919da7070287/src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantDynamic.java#L77C15-L77C15 for reference.)
Otherwise, good.

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301269: Update Commons BCEL to Version 6.7.0

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• 2cbf01c: 8312511: GHA: Bump cross-compile runner to Ubuntu 22.04
• bf70c43: 8302161: Upgrade jQuery UI to version 1.13.2
• 504ec27: 8305670: Performance regression in LockSupport.unpark with lots of idle threads
• e8a8a2d: 8292683: Remove BadKeyUsageTest.java from Problem List
• 68b3f47: 8275662: remove test/lib/sun/hotspot
• 4f4e042: 8281717: Cover logout method for several LoginModule
• baf2841: 8303279: C2: crash in SubTypeCheckNode::sub() at IGVN split if
• c2543ea: 8276333: jdk/jfr/event/oldobject/TestLargeRootSet.java failed "assert(!contains(edge->reference())) failed: invariant"
• 34da7e2: 8275415: Prepare Leak Profiler for Lilliput
• eb7900a: 8306881: Update FreeType to 2.13.0
• ... and 1 more: https://git.openjdk.org/jdk17u-dev/compare/b40b1ca1f6ab606387bb1a466810f0e23dead560...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[GoeLin]

/integrate

[openjdk]

Going to push as commit 14614f5.
Since your change was applied there have been 11 commits pushed to the master branch:

• 2cbf01c: 8312511: GHA: Bump cross-compile runner to Ubuntu 22.04
• bf70c43: 8302161: Upgrade jQuery UI to version 1.13.2
• 504ec27: 8305670: Performance regression in LockSupport.unpark with lots of idle threads
• e8a8a2d: 8292683: Remove BadKeyUsageTest.java from Problem List
• 68b3f47: 8275662: remove test/lib/sun/hotspot
• 4f4e042: 8281717: Cover logout method for several LoginModule
• baf2841: 8303279: C2: crash in SubTypeCheckNode::sub() at IGVN split if
• c2543ea: 8276333: jdk/jfr/event/oldobject/TestLargeRootSet.java failed "assert(!contains(edge->reference())) failed: invariant"
• 34da7e2: 8275415: Prepare Leak Profiler for Lilliput
• eb7900a: 8306881: Update FreeType to 2.13.0
• ... and 1 more: https://git.openjdk.org/jdk17u-dev/compare/b40b1ca1f6ab606387bb1a466810f0e23dead560...master

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin Pushed as commit 14614f5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.