Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8311285: report some fontconfig related environment variables in hs_err file #1614

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Jul 21, 2023


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8311285: report some fontconfig related environment variables in hs_err file (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1614/head:pull/1614
$ git checkout pull/1614

Update a local copy of the PR:
$ git checkout pull/1614
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1614/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1614

View PR using the GUI difftool:
$ git pr show -t 1614

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1614.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 21, 2023

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0ef03f122866f010ebf50683097e9b92e41cdaad 8311285: report some fontconfig related environment variables in hs_err file Jul 21, 2023
@openjdk
Copy link

openjdk bot commented Jul 21, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 21, 2023

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311285: report some fontconfig related environment variables in hs_err file

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 21, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 21, 2023

Webrevs

@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 25, 2023

Going to push as commit 67c5150.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 14614f5: 8301269: Update Commons BCEL to Version 6.7.0
  • 2cbf01c: 8312511: GHA: Bump cross-compile runner to Ubuntu 22.04
  • bf70c43: 8302161: Upgrade jQuery UI to version 1.13.2
  • 504ec27: 8305670: Performance regression in LockSupport.unpark with lots of idle threads
  • e8a8a2d: 8292683: Remove BadKeyUsageTest.java from Problem List
  • 68b3f47: 8275662: remove test/lib/sun/hotspot
  • 4f4e042: 8281717: Cover logout method for several LoginModule
  • baf2841: 8303279: C2: crash in SubTypeCheckNode::sub() at IGVN split if
  • c2543ea: 8276333: jdk/jfr/event/oldobject/TestLargeRootSet.java failed "assert(!contains(edge->reference())) failed: invariant"
  • 34da7e2: 8275415: Prepare Leak Profiler for Lilliput

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 25, 2023
@openjdk openjdk bot closed this Jul 25, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 25, 2023
@openjdk
Copy link

openjdk bot commented Jul 25, 2023

@MBaesken Pushed as commit 67c5150.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant