Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8296796: Provide clean, platform-agnostic interface to C-heap trimming #1615

Closed
wants to merge 2 commits into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Jul 21, 2023

A little unclean backport to provide the basis for subsequent backport:
8293114: JVM should trim the native heap

The uncleanliness comes from #include blocks and copyright lines updates.

Additional testing:

  • Trim native unit tests
  • Linux AArch64 fastdebug tier1
  • Linux AArch64 fastdebug tier2
  • Linux AArch64 fastdebug tier3

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8296796: Provide clean, platform-agnostic interface to C-heap trimming (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1615/head:pull/1615
$ git checkout pull/1615

Update a local copy of the PR:
$ git checkout pull/1615
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1615/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1615

View PR using the GUI difftool:
$ git pr show -t 1615

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1615.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 21, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0845b39caf6f04dca9cb7a5852f05b4b5ffbc034 8296796: Provide clean, platform-agnostic interface to C-heap trimming Jul 21, 2023
@openjdk
Copy link

openjdk bot commented Jul 21, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jul 21, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 21, 2023

Webrevs

Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@openjdk
Copy link

openjdk bot commented Jul 21, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296796: Provide clean, platform-agnostic interface to C-heap trimming

Reviewed-by: stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 21, 2023
@openjdk openjdk bot mentioned this pull request Jul 21, 2023
7 tasks
@shipilev
Copy link
Member Author

The RISC-V GHA needs #1613 to land in first. I'll wait for that one before integrating to make sure RISC-V parts are not broken by this.

@shipilev
Copy link
Member Author

Testing is clean. Reviews are here. Push approval is here.

/integrate

@openjdk
Copy link

openjdk bot commented Jul 25, 2023

Going to push as commit c54ecfb.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 67c5150: 8311285: report some fontconfig related environment variables in hs_err file
  • 14614f5: 8301269: Update Commons BCEL to Version 6.7.0

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 25, 2023
@openjdk openjdk bot closed this Jul 25, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 25, 2023
@openjdk
Copy link

openjdk bot commented Jul 25, 2023

@shipilev Pushed as commit c54ecfb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8296796-trim-api branch August 24, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants