-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8296796: Provide clean, platform-agnostic interface to C-heap trimming #1615
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
The RISC-V GHA needs #1613 to land in first. I'll wait for that one before integrating to make sure RISC-V parts are not broken by this. |
Testing is clean. Reviews are here. Push approval is here. /integrate |
Going to push as commit c54ecfb.
Your commit was automatically rebased without conflicts. |
A little unclean backport to provide the basis for subsequent backport:
8293114: JVM should trim the native heap
The uncleanliness comes from
#include
blocks and copyright lines updates.Additional testing:
tier1
tier2
tier3
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1615/head:pull/1615
$ git checkout pull/1615
Update a local copy of the PR:
$ git checkout pull/1615
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1615/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1615
View PR using the GUI difftool:
$ git pr show -t 1615
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1615.diff
Webrev
Link to Webrev Comment