-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8293114: JVM should trim the native heap #1616
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
|
0283f1b
to
0526220
Compare
@shipilev Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
@tstuefe, please review if you have time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good! Thanks for doing this, and sorry for the delay, I'm swamped.
I would wait a bit though, and let the patch cook upstream, before pushing. It will obviously also need https://bugs.openjdk.org/browse/JDK-8312525.
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
I think we are ready for 17u integration. Do you agree, @tstuefe? |
Hold up , I'll ask my SAP collegues first to put this through their backport CI. |
I see |
Martin reported some errors. I suspect he sees the known ones that had been fixed with 8312525, but I need to confirm. |
Okay, we see still problems in head at SAP. https://bugs.openjdk.org/browse/JDK-8314426. Lets wait with the downport till that one is fixed. Should be quick, hopefully. |
The backport looks good, but the test has issues in head as well. Thanks, Thomas, for investigating! |
No problem, we can wait for that test to be fixed, and the backport for it lined up for 17u-dev, before we proceed with this integration. Then we would not break anyone's CI, hopefully. |
OK, I lined up the backport to 17u-dev for that fix here: #1687. Assuming that passes GHA testing, are we good with integrating all three PRs in 17u-dev? I would like to reserve some time to deal with any other low-probability fallout before 17.0.9 stabilization form. |
I'm fine with it, but note that I will be gone throughout September. |
I see you have all follow-ups already neatly aligned; will you ship it today or so to still get into the rapidly closing window? |
Yes, my plan is to integrate today. I was checking if GHAs are still good with this PR. |
Testing is clean. Review is here. Push approval granted. /integrate |
Going to push as commit f667b35.
Your commit was automatically rebased without conflicts. |
Unclean backport to get useful experimental feature to LTS users.
In addition to usual contextual differences, there is a number of differences against upstream version:
synchronizer.cpp
hunks are different, since we do not have JDK-8256302 in JDK 17NativeHeapTrimmer_lock
changed fromMutex::safepoint
toMutex::leaf
, since JDK-8273915 renamed it after JDK 17NativeHeapTrimmer_lock
should also allow VMThread block and never require safepoint checks; this was simplified by JDK-8274004 latervmError.cpp
code was rewritten in JDK 17 styleEXPECT_NOT_NULL
, only brought by JDK-8295865 -- I rewrote them to EXPECT_NE/EQ.Additional testing:
tier1
tier2
tier3
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1616/head:pull/1616
$ git checkout pull/1616
Update a local copy of the PR:
$ git checkout pull/1616
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1616/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1616
View PR using the GUI difftool:
$ git pr show -t 1616
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1616.diff
Webrev
Link to Webrev Comment