Skip to content

Conversation

@SoniaZaldana
Copy link
Member

@SoniaZaldana SoniaZaldana commented Jul 26, 2023


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8273803: Zero: Handle "zero" variant in CommandLineOptionTest.java (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1627/head:pull/1627
$ git checkout pull/1627

Update a local copy of the PR:
$ git checkout pull/1627
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1627/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1627

View PR using the GUI difftool:
$ git pr show -t 1627

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1627.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 26, 2023

👋 Welcome back szaldana! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 2d13fb21af783ebbe3dd5c2632aea11347317026 8273803: Zero: Handle "zero" variant in CommandLineOptionTest.java Jul 26, 2023
@openjdk
Copy link

openjdk bot commented Jul 26, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jul 26, 2023
@openjdk
Copy link

openjdk bot commented Jul 26, 2023

@SoniaZaldana This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273803: Zero: Handle "zero" variant in CommandLineOptionTest.java

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • aaf47b3: 8307526: [JFR] Better handling of tampered JFR repository
  • 2940973: 8301367: Add exception handler method to the BaseLdapServer
  • 7d29233: 8299617: CurrencySymbols.properties is missing the copyright notice
  • 61442ce: 8296384: [TESTBUG] sun/security/provider/SecureRandom/AbstractDrbg/SpecTest.java intermittently timeout
  • 89b4429: 8293177: Verify version numbers in legal files
  • 9ed5671: 8289510: Improve test coverage for XPath Axes: namespace
  • 2a70aaa: 8270331: [TESTBUG] Error: Not a test or directory containing tests: java/awt/print/PrinterJob/InitToBlack.java
  • 90202ef: 8307165: java/awt/dnd/NoFormatsDropTest/NoFormatsDropTest.java timed out

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 26, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 26, 2023

Webrevs

@SoniaZaldana SoniaZaldana deleted the backport-8273803 branch July 26, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant