Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277762: Allow configuration of HOTSPOT_BUILD_USER #163

Conversation

andrew-m-leonard
Copy link

@andrew-m-leonard andrew-m-leonard commented Feb 15, 2022

Adds support for configure argument --with-build-user=, which allows openjdk builds to use a generic username to allow deterministic "reproducible" build output.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8277762: Allow configuration of HOTSPOT_BUILD_USER

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/163/head:pull/163
$ git checkout pull/163

Update a local copy of the PR:
$ git checkout pull/163
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/163/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 163

View PR using the GUI difftool:
$ git pr show -t 163

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/163.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 15, 2022

👋 Welcome back aleonard! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f41e768bba2b2ce3b3cc5813ccb1ac4984dcefbd 8277762: Allow configuration of HOTSPOT_BUILD_USER Feb 15, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Feb 15, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 15, 2022

@andrew-m-leonard This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277762: Allow configuration of HOTSPOT_BUILD_USER

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 0e5810d: 8274171: java/nio/file/Files/probeContentType/Basic.java failed on "Content type" mismatches
  • 2011c35: 8274562: (fs) UserDefinedFileAttributeView doesn't correctly determine if supported when using OverlayFS

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready rfr labels Feb 15, 2022
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 15, 2022

Webrevs

@andrew-m-leonard
Copy link
Author

@andrew-m-leonard andrew-m-leonard commented Feb 15, 2022

/label build

@openjdk
Copy link

@openjdk openjdk bot commented Feb 15, 2022

@andrew-m-leonard
The label build is not a valid label.
These labels are valid:

@andrew-m-leonard
Copy link
Author

@andrew-m-leonard andrew-m-leonard commented Feb 16, 2022

/integrate

@openjdk openjdk bot added the sponsor label Feb 16, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Feb 16, 2022

@andrew-m-leonard
Your change (at version 8351bac) is now ready to be sponsored by a Committer.

@andrew-m-leonard
Copy link
Author

@andrew-m-leonard andrew-m-leonard commented Feb 16, 2022

Is someone able to sponsor this please?

@phohensee
Copy link
Member

@phohensee phohensee commented Feb 17, 2022

Done.

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Feb 17, 2022

Going to push as commit 63fe160.
Since your change was applied there have been 4 commits pushed to the master branch:

  • d54675b: 8274524: SSLSocket.close() hangs if it is called during the ssl handshake
  • a59e8cb: 8278346: java/nio/file/Files/probeContentType/Basic.java fails on Linux SLES15 machine
  • 0e5810d: 8274171: java/nio/file/Files/probeContentType/Basic.java failed on "Content type" mismatches
  • 2011c35: 8274562: (fs) UserDefinedFileAttributeView doesn't correctly determine if supported when using OverlayFS

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Feb 17, 2022
@openjdk openjdk bot closed this Feb 17, 2022
@openjdk openjdk bot removed ready rfr sponsor labels Feb 17, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Feb 17, 2022

@phohensee @andrew-m-leonard Pushed as commit 63fe160.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@andrew-m-leonard
Copy link
Author

@andrew-m-leonard andrew-m-leonard commented Feb 18, 2022

thank you @phohensee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
2 participants