Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8312525: New test runtime/os/TestTrimNative.java#trimNative is failing: did not see the expected RSS reduction #1633

Closed
wants to merge 35 commits into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Jul 31, 2023

Semi-clean follow-up backport to relax the test.

There are no ProblemList additions in 17u, so this changeset does not have the relevant hunk.

Additional testing:

  • Linux x86_64 fastdebug, affected test

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Integration blocker

 ⚠️ Dependency #1616 must be integrated first

Issue

  • JDK-8312525: New test runtime/os/TestTrimNative.java#trimNative is failing: did not see the expected RSS reduction (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1633/head:pull/1633
$ git checkout pull/1633

Update a local copy of the PR:
$ git checkout pull/1633
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1633/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1633

View PR using the GUI difftool:
$ git pr show -t 1633

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1633.diff

Webrev

Link to Webrev Comment

i556354 and others added 8 commits July 26, 2023 06:17
Backport-of: 14df5c130e5bf5139e3e2ef6d7b9d64883d94d18
…ava/awt/print/PrinterJob/InitToBlack.java

Backport-of: 2ef9767aae8e1798661fea615b096833bdb9d985
Backport-of: 3d254d3c8ea7f409e8f709413f80d88913eb0ce8
Backport-of: 69ede5baeda6645aa3e961a02cbd40db965fc6a1
…ecTest.java intermittently timeout

Backport-of: 82561de722b9ca580c0c1a53050c711b64611352
Backport-of: d5b80abcbfff57c7728d3e42a696a762f08bc7ad
Backport-of: 03b23a1e1bd724019ef4fdbee3463d0646329164
Reviewed-by: lucy
Backport-of: 66d2736521611fbe7652356894d046c17d7cf743
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 31, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into pr/1616 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ad34be1f329edc8e7155983835cc70d733c014b8 8312525: New test runtime/os/TestTrimNative.java#trimNative is failing: did not see the expected RSS reduction Jul 31, 2023
@openjdk
Copy link

openjdk bot commented Jul 31, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jul 31, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 31, 2023

Webrevs

@feilongjiang
Copy link
Member

feilongjiang commented Jul 31, 2023

Seems RISC-V cross-build GHA fails again😓, the same issue also happens on mainline JDK: https://github.com/aivanov-jdk/jdk/actions/runs/5713393237/job/15480464905#step:8:889. But I don't have much clue here now.

schmelter-sap and others added 15 commits July 31, 2023 17:24
… is wrong

Backport-of: 728157fa03913991088f6bb257a8bc16706792a9
Reviewed-by: mbaesken
Backport-of: 955fc2fabafc4c4d79d137bf86194228d5cf8ad8
Backport-of: bb3e44d8b604b4e3facc4f49f625cc0b7ff2abd7
Reviewed-by: phh, fyang
Backport-of: e7adbdb1f1506b82392907f7e4a5c8882d3198eb
Backport-of: 7173c3009e0999f13eaa4bee5eedee7326f9d124
Backport-of: 2d13fb21af783ebbe3dd5c2632aea11347317026
Backport-of: 8248e351d0bed263fb68d8468004a4286e6391af
…vironment

Backport-of: a11477ce259d6d2a053117a2300ebb171145cfde
Backport-of: 21b62fef335aa981a239415532fa8b804fb5676d
Backport-of: 2adef6a1f84d478bb38b179795f08ffa43680e36
Backport-of: 07f2070411b3bff5608166ceae0e0bdbf155e7c2
Backport-of: 01b85129116dd2cc762e518ac631305bd8511764
…s with various GCs

Backport-of: d4a795d75aef8d787934f5c05e146c61138a408a
…ation

Backport-of: 05ea083b0563ddacf3e38dc329ba00dc4bac9b29
Backport-of: 89711f376751d4cfa05758705867afedfafeb602
TheRealMDoerr and others added 4 commits August 10, 2023 08:38
…le static imports

Backport-of: f79b3d42f07b703f0e3b9fc67c92dee260b0e602
Backport-of: 76cda9f44a80b1979e6e1b7a21431ef631f80782
Reviewed-by: aph
Backport-of: 1996f649a3a30b7ac4b547a762417f807f5fa414
Backport-of: 3f1174aa4709aabcfde8b40deec88b8ed466cc06
TheRealMDoerr and others added 8 commits August 11, 2023 21:24
Backport-of: c6f20db945c6217aea84cebd6c97dbf8b93c48a4
Backport-of: 82c8b28f4005c3c335d4fd60c2e3b55adfd200c6
Backport-of: dc8bc6c98ca1f9b441cf71c641675fe29dda9162
…timed out due to missing prompt

Backport-of: c84866ac0dcda487fe2abc2a8841f237df0a395b
8293098: GHA: Harmonize GCC version handling for host and cross builds
8293361: GHA: dump config.log in case of configure failure
8295213: Run GHA manually with user-specified make and configure arguments
8313428: GHA: Bump GCC versions for July 2023 updates
8313707: GHA: Bootstrap sysroots with --variant=minbase

Reviewed-by: clanger
Backport-of: d7536588b38e368eaa6395bcbcc6724a39303fc5
Backport-of: f26bd4e0e8b68de297a9ff93526cd7fac8668320
@shipilev shipilev force-pushed the JDK-8312525-trim-native-test branch from 33eb586 to 20e6716 Compare August 14, 2023 08:29
@openjdk
Copy link

openjdk bot commented Aug 14, 2023

@shipilev Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk
Copy link

openjdk bot commented Aug 14, 2023

⚠️ @shipilev This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@shipilev
Copy link
Member Author

Botched this PR. Reopening...

@shipilev shipilev closed this Aug 14, 2023
@shipilev
Copy link
Member Author

Reopened as #1662.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
10 participants