8313402: C1: Incorrect LoadIndexed value numbering

[shipilev]

Clean backport to fix the important C1 bug.

Additional testing:

• New regression test fails without the patch, passes with it, when JDK-8313676 is applied
• Linux x86_64 fastdebug tier1 tier2 tier3

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8313402: C1: Incorrect LoadIndexed value numbering (Bug - P2)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1636/head:pull/1636
$ git checkout pull/1636

Update a local copy of the PR:
$ git checkout pull/1636
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1636/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1636

View PR using the GUI difftool:
$ git pr show -t 1636

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1636.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313402: C1: Incorrect LoadIndexed value numbering

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 01: Full (09cc1cec)
• 00: Full (e8b4c93a)

[openjdk]

@shipilev Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[shipilev]

Testing is clean. Push approval is here.

/integrate

[openjdk]

Going to push as commit 528e3b8.
Since your change was applied there have been 6 commits pushed to the master branch:

• ba380ad: 8294941: GHA: Cut down cross-compilation sysroots
• b9a7231: 8294956: GHA: qemu-debootstrap is deprecated, use the regular one
• 197d2da: 8299330: Minor improvements in MSYS2 Workflow handling
• 75779ec: 8294149: JMH 1.34 and later requires jopt-simple 5.0.4
• 6985739: 8304353: Add lib-test tier1 testing in GHA
• ca0f148: 8309088: security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java fails

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 528e3b8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.