-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8278080: Add --with-cacerts-src='user cacerts folder' to enable deterministic cacerts generation #164
Conversation
👋 Welcome back aleonard! A progress list of the required criteria for merging this PR into |
This PR should be merged along with the follow up fix: openjdk/jdk@45da3ae#commitcomment-66719435 |
This backport pull request has now been updated with issue from the original commit. |
@andrew-m-leonard This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@andrew-m-leonard |
PR for https://bugs.openjdk.java.net/browse/JDK-8278163 will follow once this is merged. |
/sponsor |
Going to push as commit f6afde2.
Your commit was automatically rebased without conflicts. |
@phohensee @andrew-m-leonard Pushed as commit f6afde2. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Provide a new configure argument --with-cacerts-src=, that allows openjdk builds to specify their own source of cacerts, similar to the existing --with-cacerts-file option for pre-built ketstores, but this new option allows builds to use the GenerateCacerts openjdk tooling which produces a deterministic "reproducible" keystore.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/164/head:pull/164
$ git checkout pull/164
Update a local copy of the PR:
$ git checkout pull/164
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/164/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 164
View PR using the GUI difftool:
$ git pr show -t 164
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/164.diff