Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278080: Add --with-cacerts-src='user cacerts folder' to enable deterministic cacerts generation #164

Conversation

andrew-m-leonard
Copy link

@andrew-m-leonard andrew-m-leonard commented Feb 15, 2022

Provide a new configure argument --with-cacerts-src=, that allows openjdk builds to specify their own source of cacerts, similar to the existing --with-cacerts-file option for pre-built ketstores, but this new option allows builds to use the GenerateCacerts openjdk tooling which produces a deterministic "reproducible" keystore.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8278080: Add --with-cacerts-src='user cacerts folder' to enable deterministic cacerts generation

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/164/head:pull/164
$ git checkout pull/164

Update a local copy of the PR:
$ git checkout pull/164
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/164/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 164

View PR using the GUI difftool:
$ git pr show -t 164

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/164.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 15, 2022

👋 Welcome back aleonard! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@andrew-m-leonard
Copy link
Author

This PR should be merged along with the follow up fix: openjdk/jdk@45da3ae#commitcomment-66719435

@openjdk openjdk bot changed the title Backport dc2abc9f05c2b7c52aeb242082359c48963f9854 8278080: Add --with-cacerts-src='user cacerts folder' to enable deterministic cacerts generation Feb 15, 2022
@openjdk
Copy link

openjdk bot commented Feb 15, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 15, 2022

@andrew-m-leonard This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278080: Add --with-cacerts-src='user cacerts folder' to enable deterministic cacerts generation

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 63fe160: 8277762: Allow configuration of HOTSPOT_BUILD_USER
  • d54675b: 8274524: SSLSocket.close() hangs if it is called during the ssl handshake
  • a59e8cb: 8278346: java/nio/file/Files/probeContentType/Basic.java fails on Linux SLES15 machine
  • 0e5810d: 8274171: java/nio/file/Files/probeContentType/Basic.java failed on "Content type" mismatches

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 15, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 15, 2022

Webrevs

@andrew-m-leonard
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 18, 2022
@openjdk
Copy link

openjdk bot commented Feb 18, 2022

@andrew-m-leonard
Your change (at version 212ebf7) is now ready to be sponsored by a Committer.

@andrew-m-leonard
Copy link
Author

PR for https://bugs.openjdk.java.net/browse/JDK-8278163 will follow once this is merged.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 18, 2022

Going to push as commit f6afde2.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 63fe160: 8277762: Allow configuration of HOTSPOT_BUILD_USER
  • d54675b: 8274524: SSLSocket.close() hangs if it is called during the ssl handshake
  • a59e8cb: 8278346: java/nio/file/Files/probeContentType/Basic.java fails on Linux SLES15 machine
  • 0e5810d: 8274171: java/nio/file/Files/probeContentType/Basic.java failed on "Content type" mismatches

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 18, 2022
@openjdk openjdk bot closed this Feb 18, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 18, 2022
@openjdk
Copy link

openjdk bot commented Feb 18, 2022

@phohensee @andrew-m-leonard Pushed as commit f6afde2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants