Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8310551: vmTestbase/nsk/jdb/interrupt/interrupt001/interrupt001.java timed out due to missing prompt #1654

Closed

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Aug 9, 2023

Backport of JDK-8310551. Applies cleanly except removal from ProblemList. (Not problem listed in 17u). Test has passed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8310551: vmTestbase/nsk/jdb/interrupt/interrupt001/interrupt001.java timed out due to missing prompt (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1654/head:pull/1654
$ git checkout pull/1654

Update a local copy of the PR:
$ git checkout pull/1654
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1654/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1654

View PR using the GUI difftool:
$ git pr show -t 1654

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1654.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 9, 2023

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c84866ac0dcda487fe2abc2a8841f237df0a395b 8310551: vmTestbase/nsk/jdb/interrupt/interrupt001/interrupt001.java timed out due to missing prompt Aug 9, 2023
@openjdk
Copy link

openjdk bot commented Aug 9, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Aug 9, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 9, 2023

Webrevs

@TheRealMDoerr
Copy link
Contributor Author

/clean

@openjdk openjdk bot added the clean label Aug 10, 2023
@openjdk
Copy link

openjdk bot commented Aug 10, 2023

@TheRealMDoerr This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Aug 10, 2023

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310551: vmTestbase/nsk/jdb/interrupt/interrupt001/interrupt001.java timed out due to missing prompt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • fe9b7c6: 8255548: Missing coverage for javax.xml.crypto.dom.DOMCryptoContext
  • 242513f: 6381945: (cal) Japanese calendar unit test system should avoid multiple static imports
  • 3d86810: 8307079: Update test java/awt/Choice/DragOffNoSelect.java
  • 8aad696: 8301167: Update VerifySignedJar to actually exercise and test verification
  • fe3920e: 8283276: java/io/ObjectStreamClass/ObjectStreamClassCaching.java fails with various GCs
  • ec2abc2: 8302182: Update Public Suffix List to 88467c9

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 10, 2023
@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 11, 2023

Going to push as commit d7b3306.
Since your change was applied there have been 11 commits pushed to the master branch:

  • 6ab5177: 8308090: Add container tests for on-the-fly resource quota updates
  • 10942c1: 8156889: ListKeychainStore.sh fails in some virtualized environments
  • 8683db8: 8308232: nsk/jdb tests don't pass -verbose flag to the debuggee
  • 38204b0: 8289646: configure script failed on WSL
  • 762c351: 8273092: Sort classlist in JDK image
  • fe9b7c6: 8255548: Missing coverage for javax.xml.crypto.dom.DOMCryptoContext
  • 242513f: 6381945: (cal) Japanese calendar unit test system should avoid multiple static imports
  • 3d86810: 8307079: Update test java/awt/Choice/DragOffNoSelect.java
  • 8aad696: 8301167: Update VerifySignedJar to actually exercise and test verification
  • fe3920e: 8283276: java/io/ObjectStreamClass/ObjectStreamClassCaching.java fails with various GCs
  • ... and 1 more: https://git.openjdk.org/jdk17u-dev/compare/9c8731bddeff5c134d81c1d3f9c0f3dea43dde5f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 11, 2023
@openjdk openjdk bot closed this Aug 11, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 11, 2023
@openjdk
Copy link

openjdk bot commented Aug 11, 2023

@TheRealMDoerr Pushed as commit d7b3306.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr TheRealMDoerr deleted the 8310551_interrupt001 branch August 11, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant