Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8281460: Let ObjectMonitor have its own NMT category #166

Closed

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented Feb 16, 2022

Hi all,

Clean backport, small fix and low risk.

I'd like to backport this to make it more obvious if a VM uses a lot of memory for Object Monitors. Before this patch, this number was hidden in mtInternal.

Thanks, Thomas


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8281460: Let ObjectMonitor have its own NMT category

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/166/head:pull/166
$ git checkout pull/166

Update a local copy of the PR:
$ git checkout pull/166
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/166/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 166

View PR using the GUI difftool:
$ git pr show -t 166

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/166.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 16, 2022

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a037b3c35831f029d23a88bdd49e7f2c2d951631 8281460: Let ObjectMonitor have its own NMT category Feb 16, 2022
@openjdk
Copy link

openjdk bot commented Feb 16, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 16, 2022

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8281460: Let ObjectMonitor have its own NMT category

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 16, 2022
@tstuefe tstuefe marked this pull request as ready for review February 16, 2022 11:40
@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 16, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 16, 2022

Webrevs

@tstuefe
Copy link
Member Author

tstuefe commented Feb 25, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Feb 25, 2022

Going to push as commit 6650652.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 56f0c53: 8278163: --with-cacerts-src variable resolved after GenerateCacerts recipe setup
  • 0c6e662: 8277383: VM.metaspace optionally show chunk freelist details
  • 9bb8b7f: 8271721: Split gc/g1/TestMixedGCLiveThreshold into separate tests
  • 5de8b78: 8277488: Add expiry exception for Digicert (geotrustglobalca) expiring in May 2022
  • f7f0b31: 8270117: Broken jtreg link in "Building the JDK" page
  • cf55b1b: 8279695: [TESTBUG] modify compiler/loopopts/TestSkeletonPredicateNegation.java to run on C1 also
  • f6afde2: 8278080: Add --with-cacerts-src='user cacerts folder' to enable deterministic cacerts generation
  • 63fe160: 8277762: Allow configuration of HOTSPOT_BUILD_USER
  • d54675b: 8274524: SSLSocket.close() hangs if it is called during the ssl handshake
  • a59e8cb: 8278346: java/nio/file/Files/probeContentType/Basic.java fails on Linux SLES15 machine

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 25, 2022
@openjdk openjdk bot closed this Feb 25, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 25, 2022
@openjdk
Copy link

openjdk bot commented Feb 25, 2022

@tstuefe Pushed as commit 6650652.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant