Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8313796: AsyncGetCallTrace crash on unreadable interpreter method pointer #1665

Closed
wants to merge 1 commit into from

Conversation

benty-amzn
Copy link

@benty-amzn benty-amzn commented Aug 15, 2023

Backort 8313796 to resolve a hotspot crash. Backport is clean and passes jtreg tier 1-4 tests.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8313796: AsyncGetCallTrace crash on unreadable interpreter method pointer (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1665/head:pull/1665
$ git checkout pull/1665

Update a local copy of the PR:
$ git checkout pull/1665
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1665/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1665

View PR using the GUI difftool:
$ git pr show -t 1665

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1665.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 15, 2023

👋 Welcome back btaylor! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0e2c72d7a5206b7173af5bf69e21d21ea276bd94 8313796: AsyncGetCallTrace crash on unreadable interpreter method pointer Aug 15, 2023
@openjdk
Copy link

openjdk bot commented Aug 15, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 15, 2023

@benty-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313796: AsyncGetCallTrace crash on unreadable interpreter method pointer

Reviewed-by: stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 528e3b8: 8313402: C1: Incorrect LoadIndexed value numbering
  • ba380ad: 8294941: GHA: Cut down cross-compilation sysroots
  • b9a7231: 8294956: GHA: qemu-debootstrap is deprecated, use the regular one
  • 197d2da: 8299330: Minor improvements in MSYS2 Workflow handling
  • 75779ec: 8294149: JMH 1.34 and later requires jopt-simple 5.0.4
  • 6985739: 8304353: Add lib-test tier1 testing in GHA

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@tstuefe) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 15, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 15, 2023

Webrevs

Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@benty-amzn
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 16, 2023
@openjdk
Copy link

openjdk bot commented Aug 16, 2023

@benty-amzn
Your change (at version 4d1a816) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 16, 2023

Going to push as commit 4084a81.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 528e3b8: 8313402: C1: Incorrect LoadIndexed value numbering
  • ba380ad: 8294941: GHA: Cut down cross-compilation sysroots
  • b9a7231: 8294956: GHA: qemu-debootstrap is deprecated, use the regular one
  • 197d2da: 8299330: Minor improvements in MSYS2 Workflow handling
  • 75779ec: 8294149: JMH 1.34 and later requires jopt-simple 5.0.4
  • 6985739: 8304353: Add lib-test tier1 testing in GHA

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 16, 2023
@openjdk openjdk bot closed this Aug 16, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 16, 2023
@openjdk
Copy link

openjdk bot commented Aug 16, 2023

@phohensee @benty-amzn Pushed as commit 4084a81.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
3 participants