Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8168469: Memory leak in JceSecurity #1671

Conversation

sercher
Copy link
Contributor

@sercher sercher commented Aug 17, 2023

The patch did not apply cleanly: updated the copyright header.

All tests in javax/crypto, sun/security, com/sun/crypto pass. The new test fails before the fix and passes after the fix.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8168469 needs maintainer approval

Issue

  • JDK-8168469: Memory leak in JceSecurity (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1671/head:pull/1671
$ git checkout pull/1671

Update a local copy of the PR:
$ git checkout pull/1671
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1671/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1671

View PR using the GUI difftool:
$ git pr show -t 1671

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1671.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 17, 2023

👋 Welcome back schernyshev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a284920b3432b00496a2a32a284a91a9bd49fb06 8168469: Memory leak in JceSecurity Aug 17, 2023
@openjdk
Copy link

openjdk bot commented Aug 17, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Aug 17, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 17, 2023

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Aug 20, 2023

Please enable github actions for this repo.
Please label again if the change is ready, i.e. tested and reviewed.

@sercher
Copy link
Contributor Author

sercher commented Aug 21, 2023

Thank you Goetz, I enabled the github actions and reran the tests manually.

@sercher
Copy link
Contributor Author

sercher commented Sep 15, 2023

Could anyone please help reviewing this backport?

@phohensee
Copy link
Member

/clean

@openjdk openjdk bot added the clean label Sep 15, 2023
@openjdk
Copy link

openjdk bot commented Sep 15, 2023

@phohensee This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Sep 15, 2023

⚠️ @sercher This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval label Sep 18, 2023
@openjdk
Copy link

openjdk bot commented Sep 19, 2023

@sercher This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8168469: Memory leak in JceSecurity

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 80 new commits pushed to the master branch:

  • 1a68e52: 8314679: SA fails to properly attach to JVM after having just detached from a different JVM
  • 7588666: 8313657: com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors
  • a3e8026: 8294427: Check boxes and radio buttons have rendering issues on Windows in High DPI env
  • d2045f9: 8265586: [windows] last button is not shown in AWT Frame with BorderLayout and MenuBar set.
  • f3ee6ea: 8061729: Update java/net tests to eliminate dependency on sun.net.www.MessageHeader and some other internal APIs
  • f908cee: 8270447: [IR Framework] Add missing compilation level restriction when using FlipC1C2 stress option
  • be52dc5: 8247351: [aarch64] NullPointerException during stack walking (clhsdb "where -a")
  • 1ce12c4: 8312065: Socket.connect does not timeout when profiling
  • fee0229: 8312909: C1 should not inline through interface calls with non-subtype receiver
  • 955dcb3: 8312573: Failure during CompileOnly parsing leads to ShouldNotReachHere
  • ... and 70 more: https://git.openjdk.org/jdk17u-dev/compare/4084a8181337999b87cf89950f2401b1b78204dc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Sep 19, 2023
@sercher
Copy link
Contributor Author

sercher commented Sep 20, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 20, 2023
@openjdk
Copy link

openjdk bot commented Sep 20, 2023

@sercher
Your change (at version eec93f5) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 20, 2023

Going to push as commit a06047a.
Since your change was applied there have been 80 commits pushed to the master branch:

  • 1a68e52: 8314679: SA fails to properly attach to JVM after having just detached from a different JVM
  • 7588666: 8313657: com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors
  • a3e8026: 8294427: Check boxes and radio buttons have rendering issues on Windows in High DPI env
  • d2045f9: 8265586: [windows] last button is not shown in AWT Frame with BorderLayout and MenuBar set.
  • f3ee6ea: 8061729: Update java/net tests to eliminate dependency on sun.net.www.MessageHeader and some other internal APIs
  • f908cee: 8270447: [IR Framework] Add missing compilation level restriction when using FlipC1C2 stress option
  • be52dc5: 8247351: [aarch64] NullPointerException during stack walking (clhsdb "where -a")
  • 1ce12c4: 8312065: Socket.connect does not timeout when profiling
  • fee0229: 8312909: C1 should not inline through interface calls with non-subtype receiver
  • 955dcb3: 8312573: Failure during CompileOnly parsing leads to ShouldNotReachHere
  • ... and 70 more: https://git.openjdk.org/jdk17u-dev/compare/4084a8181337999b87cf89950f2401b1b78204dc...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 20, 2023
@openjdk openjdk bot closed this Sep 20, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 20, 2023
@openjdk
Copy link

openjdk bot commented Sep 20, 2023

@phohensee @sercher Pushed as commit a06047a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
3 participants