8314552: Fix javadoc tests to work with jtreg 7

[lutkerd]

Updating the tests to specify a UTF-8 encoding so that they work with jtreg-7 and the embedded testng jar.

bash ./configure --with-jtreg=jtreg-7.3+1
make images
make run-test TEST="jtreg:test/langtools/jdk/javadoc/doclet"

All tests pass.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8314552: Fix javadoc tests to work with jtreg 7 (Bug - P4)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)
• Aleksey Shipilev (@shipilev - Reviewer)
• Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1672/head:pull/1672
$ git checkout pull/1672

Update a local copy of the PR:
$ git checkout pull/1672
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1672/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1672

View PR using the GUI difftool:
$ git pr show -t 1672

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1672.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back lutkerd! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 03: Full (a42733a9)
• 02: Full (95a063d6)
• 01: Full - Incremental (c81dda6e)
• 00: Full (f11a581b)

[gnu-andrew]

Can you make this target pr/1595 instead of master? Then we can see if it fixes the issue we're seeing on that PR.

The tests work for me locally with JTReg 7 without this patch. We need to know if fixes things in GHA.

Thanks.

[openjdk]

@lutkerd Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[lutkerd]

Can you make this target pr/1595 instead of master? Then we can see if it fixes the issue we're seeing on that PR.

The tests work for me locally with JTReg 7 without this patch. We need to know if fixes things in GHA.

Thanks.

And now we hit the GCC version issue....
Can you forward port openjdk/jdk11u-dev#2087 and then we can target pr/1595 onto that and maybe all should work?

[gnu-andrew]

Done: #1673

Note that this would probably be resolved by merging with jdk17u-dev/master alone, as I did first (the versions were bumped after 1595 was made), but you may as well just make this dependent on 1673 now.

[openjdk]

@lutkerd Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[lutkerd]

Updated the target, let's see how this goes.

[shipilev]

This PR does not need to depend on openjdk:pr/1673. Current jdk17u-dev should compile fine, it is just your personal fork is way too old: "This branch is 1 commit ahead, 1480 commits behind openjdk:master."

Please pull new jdk17u-dev to your personal fork, and then rebase for new master. This will let you integrate this PR without waiting unnecessarily for openjdk:pr/1673 to integrate.

[GoeLin]

Thanks for fixing this!

[GoeLin]

You need to update the branch please so that it can be marked ready.

[openjdk]

@lutkerd Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[lutkerd]

Rebased and updated to target master so it can be merged on its own.

[openjdk]

@lutkerd This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314552: Fix javadoc tests to work with jtreg 7

Reviewed-by: phh, shade, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 49ffbcf: 8314501: Shenandoah: sun/tools/jhsdb/heapconfig/JMapHeapConfigTest.java fails
• d35a896: 8293851: hs_err should print more stack in hex dump
• 3f8e995: 8314658: [17u] GHA: Sync up debian-version for cross-builds

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee, @shipilev, @gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[phohensee]

Still good.

[gnu-andrew]

This PR does not need to depend on openjdk:pr/1673. Current jdk17u-dev should compile fine, it is just your personal fork is way too old: "This branch is 1 commit ahead, 1480 commits behind openjdk:master."

Please pull new jdk17u-dev to your personal fork, and then rebase for new master. This will let you integrate this PR without waiting unnecessarily for openjdk:pr/1673 to integrate.

Yes, as I mentioned above. This was just a quick way to see if it would make the tests pass. There's actually no reason for this to even wait on the JTreg update as it's independent of that (and GHA show tests passing).

[gnu-andrew]

Changes look good and pass on both JTreg 6 & 7. Approved for 17u.

[lutkerd]

/integrate

[openjdk]

@lutkerd
Your change (at version a42733a) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit e830464.
Since your change was applied there have been 3 commits pushed to the master branch:

• 49ffbcf: 8314501: Shenandoah: sun/tools/jhsdb/heapconfig/JMapHeapConfigTest.java fails
• d35a896: 8293851: hs_err should print more stack in hex dump
• 3f8e995: 8314658: [17u] GHA: Sync up debian-version for cross-builds

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @lutkerd Pushed as commit e830464.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.