-
Notifications
You must be signed in to change notification settings - Fork 232
8313701: GHA: RISC-V should use the official repository for bootstrap #1680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
|
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 6 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
Push approval granted. RISC-V sysroot creation should be fixed after we integrate another PR, mentioned above. /integrate |
|
Going to push as commit e84d9dd.
Your commit was automatically rebased without conflicts. |
Unclean backport to improve GHA stability. The conflict is due to RISC-V GHA changes of the slightly different form in 17u: does not have explicit
keyringhandling blocks. That block is going away with another clean up upstream, so I just resolved the conflict to only update thedebian-repositoryitself.Additional testing:
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1680/head:pull/1680$ git checkout pull/1680Update a local copy of the PR:
$ git checkout pull/1680$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1680/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1680View PR using the GUI difftool:
$ git pr show -t 1680Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1680.diff
Webrev
Link to Webrev Comment