Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314426: runtime/os/TestTrimNative.java is failing on slow machines #1687

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Aug 23, 2023

Clean backport, further stabilization of the test.

Additional testing:

  • 100+ iterations of affected test on Linux x86_64 fastdebug

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8314426: runtime/os/TestTrimNative.java is failing on slow machines (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1687/head:pull/1687
$ git checkout pull/1687

Update a local copy of the PR:
$ git checkout pull/1687
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1687/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1687

View PR using the GUI difftool:
$ git pr show -t 1687

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1687.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 23, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into pr/1662 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 20e94784c9f7c30e95550c72aedb5e986a153114 8314426: runtime/os/TestTrimNative.java is failing on slow machines Aug 23, 2023
@openjdk
Copy link

openjdk bot commented Aug 23, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Aug 23, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 23, 2023

Webrevs

Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/1662 to master August 25, 2023 14:34
@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout JDK-8314426-trimnative-test-slow
git fetch https://git.openjdk.org/jdk17u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@shipilev shipilev force-pushed the JDK-8314426-trimnative-test-slow branch from a623b67 to 10e4de6 Compare August 25, 2023 14:34
@openjdk
Copy link

openjdk bot commented Aug 25, 2023

@shipilev Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk
Copy link

openjdk bot commented Aug 25, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314426: runtime/os/TestTrimNative.java is failing on slow machines

Reviewed-by: stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 25, 2023
@shipilev
Copy link
Member Author

Testing was clean before rebase. Local testing passes. Review is here. Push approval granted.

/integrate

@openjdk
Copy link

openjdk bot commented Aug 25, 2023

Going to push as commit fdc4130.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 25, 2023
@openjdk openjdk bot closed this Aug 25, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 25, 2023
@openjdk
Copy link

openjdk bot commented Aug 25, 2023

@shipilev Pushed as commit fdc4130.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8314426-trimnative-test-slow branch December 11, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants