-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8314426: runtime/os/TestTrimNative.java is failing on slow machines #1687
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
20e6716
to
463ffc6
Compare
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout JDK-8314426-trimnative-test-slow
git fetch https://git.openjdk.org/jdk17u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
a623b67
to
10e4de6
Compare
@shipilev Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Testing was clean before rebase. Local testing passes. Review is here. Push approval granted. /integrate |
Going to push as commit fdc4130. |
Clean backport, further stabilization of the test.
Additional testing:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1687/head:pull/1687
$ git checkout pull/1687
Update a local copy of the PR:
$ git checkout pull/1687
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1687/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1687
View PR using the GUI difftool:
$ git pr show -t 1687
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1687.diff
Webrev
Link to Webrev Comment