Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8313874: JNI NewWeakGlobalRef throws exception for null arg #1688

Conversation

olivergillespie
Copy link
Contributor

@olivergillespie olivergillespie commented Aug 23, 2023

Nearly clean backport for https://bugs.openjdk.org/browse/JDK-8313874, the only difference is 17 using NULL compared to nullptr in tip required a manual (but trivial) merge.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8313874: JNI NewWeakGlobalRef throws exception for null arg (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1688/head:pull/1688
$ git checkout pull/1688

Update a local copy of the PR:
$ git checkout pull/1688
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1688/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1688

View PR using the GUI difftool:
$ git pr show -t 1688

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1688.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 23, 2023

👋 Welcome back ogillespie! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 028b3ae1b162bd8f7c340bfa6e9487ca83697955 8313874: JNI NewWeakGlobalRef throws exception for null arg Aug 23, 2023
@openjdk
Copy link

openjdk bot commented Aug 23, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Aug 23, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 23, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 23, 2023

@olivergillespie This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313874: JNI NewWeakGlobalRef throws exception for null arg

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

  • d82de1c: 8314517: some tests fail in case ipv6 is disabled on the machine
  • 1d65a31: 8284772: GHA: Use GCC Major Version Dependencies Only
  • 47ed2e5: 8311033: [macos] PrinterJob does not take into account Sides attribute
  • 4c123ac: 8295737: macOS: Print content cut off when width > height with portrait orientation
  • 7286bb8: 8313815: The exception messages printed by jcmd ManagementAgent.start are corrupted on Japanese Windows
  • fdc4130: 8314426: runtime/os/TestTrimNative.java is failing on slow machines
  • 3c426c7: 8312525: New test runtime/os/TestTrimNative.java#trimNative is failing: did not see the expected RSS reduction
  • f667b35: 8293114: JVM should trim the native heap
  • 1421540: 8276651: java/lang/ProcessHandle tests fail with "RuntimeException: Input/output error" in java.lang.ProcessHandleImpl$Info.info0
  • d9985d0: 8314730: GHA: Drop libfreetype6-dev transitional package in favor of libfreetype-dev
  • ... and 7 more: https://git.openjdk.org/jdk17u-dev/compare/994f16fe74f0050b7f474a86dd9088451bd554df...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 23, 2023
@olivergillespie
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 29, 2023
@openjdk
Copy link

openjdk bot commented Aug 29, 2023

@olivergillespie
Your change (at version 8cb1d0c) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 29, 2023

Going to push as commit c91fb3f.
Since your change was applied there have been 20 commits pushed to the master branch:

  • 7ea65a0: Merge
  • 0f29caa: 8313765: Invalid CEN header (invalid zip64 extra data field size)
  • b31f232: 8314677: Bump update version for OpenJDK: jdk-17.0.8.1
  • d82de1c: 8314517: some tests fail in case ipv6 is disabled on the machine
  • 1d65a31: 8284772: GHA: Use GCC Major Version Dependencies Only
  • 47ed2e5: 8311033: [macos] PrinterJob does not take into account Sides attribute
  • 4c123ac: 8295737: macOS: Print content cut off when width > height with portrait orientation
  • 7286bb8: 8313815: The exception messages printed by jcmd ManagementAgent.start are corrupted on Japanese Windows
  • fdc4130: 8314426: runtime/os/TestTrimNative.java is failing on slow machines
  • 3c426c7: 8312525: New test runtime/os/TestTrimNative.java#trimNative is failing: did not see the expected RSS reduction
  • ... and 10 more: https://git.openjdk.org/jdk17u-dev/compare/994f16fe74f0050b7f474a86dd9088451bd554df...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 29, 2023
@openjdk openjdk bot closed this Aug 29, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 29, 2023
@openjdk
Copy link

openjdk bot commented Aug 29, 2023

@phohensee @olivergillespie Pushed as commit c91fb3f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@olivergillespie olivergillespie deleted the olivergillespie-backport-028b3ae1 branch August 29, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants