Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8312535: MidiSystem.getSoundbank() throws unexpected SecurityException #1689

Closed
wants to merge 3 commits into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Aug 24, 2023

Hi all,

This pull request contains a backport of commit 87298d2a from the openjdk/jdk repository.

The commit being backported was authored by Sergey Bylokhov on 22 Aug 2023 and was reviewed by Phil Race.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8312535: MidiSystem.getSoundbank() throws unexpected SecurityException (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1689/head:pull/1689
$ git checkout pull/1689

Update a local copy of the PR:
$ git checkout pull/1689
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1689/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1689

View PR using the GUI difftool:
$ git pr show -t 1689

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1689.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 24, 2023

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 87298d2ade41c689d3140981a123b0e9130fc651 8312535: MidiSystem.getSoundbank() throws unexpected SecurityException Aug 24, 2023
@openjdk
Copy link

openjdk bot commented Aug 24, 2023

This backport pull request has now been updated with issue from the original commit.

@mrserb mrserb marked this pull request as ready for review August 24, 2023 18:15
@openjdk
Copy link

openjdk bot commented Aug 24, 2023

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312535: MidiSystem.getSoundbank() throws unexpected SecurityException

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • a64639f: 8312974: Bump update version for OpenJDK: jdk-17.0.10
  • 25efecc: 8313262: C2: Sinking node may cause required cast to be dropped
  • f09ba79: 8314020: Print instruction blocks in byte units

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 24, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 24, 2023

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Aug 29, 2023

Hi,
what is wrong with the pre submit tests?

@mrserb
Copy link
Member Author

mrserb commented Aug 29, 2023

what is wrong with the pre submit tests?

That tasks failed to start due to timeout, seems too many tasks were submitted at that moment.

@mrserb
Copy link
Member Author

mrserb commented Aug 31, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Aug 31, 2023

Going to push as commit e0b39c7.
Since your change was applied there have been 8 commits pushed to the master branch:

  • e6b87a7: 8312182: THPs cause huge RSS due to thread start timing issue
  • fbe3773: 8312394: [linux] SIGSEGV if kernel was built without hugepage support
  • 0d4fbb4: 8295229: Try to verify gtest version
  • 3681719: 8310233: Fix THP detection on Linux
  • 0bc4e7e: 8292717: Clean up checking of testing requirements in configure
  • a64639f: 8312974: Bump update version for OpenJDK: jdk-17.0.10
  • 25efecc: 8313262: C2: Sinking node may cause required cast to be dropped
  • f09ba79: 8314020: Print instruction blocks in byte units

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 31, 2023
@openjdk openjdk bot closed this Aug 31, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 31, 2023
@openjdk
Copy link

openjdk bot commented Aug 31, 2023

@mrserb Pushed as commit e0b39c7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants