Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8313262: C2: Sinking node may cause required cast to be dropped #1690

Closed
wants to merge 2 commits into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Aug 24, 2023

Clean backport to fix recent JDK 17 backport regression.

Additional testing:

  • New test fails without the fix, passes with it
  • Linux x86_64 fastdebug tier1 tier2 tier3

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8313262: C2: Sinking node may cause required cast to be dropped (Bug - P2)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1690/head:pull/1690
$ git checkout pull/1690

Update a local copy of the PR:
$ git checkout pull/1690
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1690/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1690

View PR using the GUI difftool:
$ git pr show -t 1690

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1690.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 24, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1cee3b9fd9720e7938029a6992460b9053e65e57 8313262: C2: Sinking node may cause required cast to be dropped Aug 24, 2023
@openjdk
Copy link

openjdk bot commented Aug 24, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 24, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313262: C2:  Sinking node may cause required cast to be dropped

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 24, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 24, 2023

Webrevs

@shipilev
Copy link
Member Author

Patch is clean. Testing is passing. Push approval granted.

/integrate

@openjdk
Copy link

openjdk bot commented Aug 30, 2023

Going to push as commit 25efecc.
Since your change was applied there have been 15 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 30, 2023
@openjdk openjdk bot closed this Aug 30, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 30, 2023
@openjdk
Copy link

openjdk bot commented Aug 30, 2023

@shipilev Pushed as commit 25efecc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8313262-c2-sinking-node branch December 11, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant