-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8292717: Clean up checking of testing requirements in configure #1693
8292717: Clean up checking of testing requirements in configure #1693
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
… in configure Hash: 16593cf51c3d994ba4a6d28ab97e519dfd53f37b
…the required version
e35844e
to
a02907d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 17 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Review is here. Push approval is granted. /integrate |
Going to push as commit 0bc4e7e.
Your commit was automatically rebased without conflicts. |
Prepares build system for cleaner googletest and jtreg dependency updates. After this, at least googletest update applies only with minor conflicts. I expect jtreg updates would be smoother too.
Current backport does not apply cleanly, because prior backports are in the way. So I did this PR by reverting JDK-8292716 and JDK-8292763 fixes, applying this move cleanly, and then reapplying the first two cleanly. Therefore both JDK-8292716 and JDK-8292763 still effectively remain in 17u-dev. See commit history for individual commits. This also makes sure we do not miss anything in backports.
@GoeLin, you might want to take a look.
Additional testing:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1693/head:pull/1693
$ git checkout pull/1693
Update a local copy of the PR:
$ git checkout pull/1693
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1693/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1693
View PR using the GUI difftool:
$ git pr show -t 1693
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1693.diff
Webrev
Link to Webrev Comment