Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8312182: THPs cause huge RSS due to thread start timing issue #1697

Closed
wants to merge 1 commit into from

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented Aug 25, 2023

Clean backport. Fixes a serious issue that may cause huge RSS bloat and thread start performance degradation.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8312182: THPs cause huge RSS due to thread start timing issue (Bug - P3)
  • JDK-8310687: JDK-8303215 is incomplete (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1697/head:pull/1697
$ git checkout pull/1697

Update a local copy of the PR:
$ git checkout pull/1697
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1697/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1697

View PR using the GUI difftool:
$ git pr show -t 1697

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1697.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 25, 2023

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 84b325b844c08809448a9c073a11443d9e3c3f8e 8312182: THPs cause huge RSS due to thread start timing issue Aug 25, 2023
@openjdk
Copy link

openjdk bot commented Aug 25, 2023

This backport pull request has now been updated with issues from the original commit.

@openjdk openjdk bot added the backport label Aug 25, 2023
@openjdk openjdk bot added the clean label Aug 30, 2023
@tstuefe
Copy link
Member Author

tstuefe commented Aug 30, 2023

/clean

@tstuefe tstuefe marked this pull request as ready for review August 30, 2023 09:33
@openjdk
Copy link

openjdk bot commented Aug 30, 2023

@tstuefe This backport pull request is already marked as clean

@openjdk
Copy link

openjdk bot commented Aug 30, 2023

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312182: THPs cause huge RSS due to thread start timing issue
8310687: JDK-8303215 is incomplete

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 30, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 30, 2023

Webrevs

@tstuefe
Copy link
Member Author

tstuefe commented Aug 30, 2023

Tests clean, push approval granted.

/integrate

@openjdk
Copy link

openjdk bot commented Aug 30, 2023

Going to push as commit e6b87a7.
Since your change was applied there have been 2 commits pushed to the master branch:

  • fbe3773: 8312394: [linux] SIGSEGV if kernel was built without hugepage support
  • 0d4fbb4: 8295229: Try to verify gtest version

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 30, 2023
@openjdk openjdk bot closed this Aug 30, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 30, 2023
@openjdk
Copy link

openjdk bot commented Aug 30, 2023

@tstuefe Pushed as commit e6b87a7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant