Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314139: TEST_BUG: runtime/os/THPsInThreadStackPreventionTest.java could fail on machine with large number of cores #1698

Closed
wants to merge 2 commits into from

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented Aug 25, 2023

Clean backport to stabilize test after 8312182.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8314139: TEST_BUG: runtime/os/THPsInThreadStackPreventionTest.java could fail on machine with large number of cores (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1698/head:pull/1698
$ git checkout pull/1698

Update a local copy of the PR:
$ git checkout pull/1698
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1698/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1698

View PR using the GUI difftool:
$ git pr show -t 1698

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1698.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 25, 2023

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 733250288325bc663afc0376342d4c5a7a471cbd 8314139: TEST_BUG: runtime/os/THPsInThreadStackPreventionTest.java could fail on machine with large number of cores Aug 25, 2023
@openjdk
Copy link

openjdk bot commented Aug 25, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Aug 25, 2023
@tstuefe tstuefe force-pushed the tstuefe-backport-73325028 branch from 91110b9 to be2cc9e Compare August 30, 2023 09:50
@tstuefe tstuefe force-pushed the tstuefe-backport-73325028 branch from be2cc9e to cb3d4e3 Compare August 30, 2023 18:25
@tstuefe tstuefe marked this pull request as ready for review August 30, 2023 18:26
@tstuefe
Copy link
Member Author

tstuefe commented Aug 30, 2023

/clean

@openjdk openjdk bot added the clean label Aug 30, 2023
@openjdk
Copy link

openjdk bot commented Aug 30, 2023

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314139: TEST_BUG: runtime/os/THPsInThreadStackPreventionTest.java could fail on machine with large number of cores

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 30, 2023
@openjdk
Copy link

openjdk bot commented Aug 30, 2023

@tstuefe This backport pull request is already marked as clean

@mlbridge
Copy link

mlbridge bot commented Aug 30, 2023

Webrevs

@tstuefe
Copy link
Member Author

tstuefe commented Aug 31, 2023

Got approval. Last tests had been successful.

/integrate

@openjdk
Copy link

openjdk bot commented Aug 31, 2023

Going to push as commit f85df30.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 31, 2023
@openjdk openjdk bot closed this Aug 31, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 31, 2023
@openjdk
Copy link

openjdk bot commented Aug 31, 2023

@tstuefe Pushed as commit f85df30.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant