Skip to content

8225559: assertion error at TransTypes.visitApply #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

cushon
Copy link
Contributor

@cushon cushon commented Dec 21, 2021

This is a backport of JDK-8225559: assertion error at TransTypes.visitApply

The patch applied cleanly.

Testing: tier1 langtools tests


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8225559: assertion error at TransTypes.visitApply

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/17/head:pull/17
$ git checkout pull/17

Update a local copy of the PR:
$ git checkout pull/17
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/17/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17

View PR using the GUI difftool:
$ git pr show -t 17

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/17.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 21, 2021

👋 Welcome back cushon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport de61328d30e4d022c2609b2947bafe4b36cc1293 8225559: assertion error at TransTypes.visitApply Dec 21, 2021
@openjdk
Copy link

openjdk bot commented Dec 21, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 21, 2021

@cushon This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8225559: assertion error at TransTypes.visitApply

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • cc4a0b1: 8278016: Add compiler tests to tier{2,3}

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 21, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 21, 2021

Webrevs

@cushon
Copy link
Contributor Author

cushon commented Dec 22, 2021

JDK-8225559 has been tagged jdk17u-fix-yes

@cushon
Copy link
Contributor Author

cushon commented Dec 22, 2021

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 22, 2021
@openjdk
Copy link

openjdk bot commented Dec 22, 2021

@cushon
Your change (at version efa47af) is now ready to be sponsored by a Committer.

@RealCLanger
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 11, 2022

Going to push as commit 75f8752.
Since your change was applied there have been 57 commits pushed to the master branch:

  • 9f97c82: 8276654: element-list order is non deterministic
  • 6884635: 8279300: [arm32] SIGILL when running GetObjectSizeIntrinsicsTest
  • 7f684c3: 8273682: Upgrade Jline to 3.20.0
  • d716c2b: 8278758: runtime/BootstrapMethod/BSMCalledTwice.java fails with release VMs after JDK-8262134
  • 6c0f974: 8262134: compiler/uncommontrap/TestDeoptOOM.java failed with "guarantee(false) failed: wrong number of expression stack elements during deopt"
  • 832a570: 8269037: jsig/Testjsig.java doesn't have to be restricted to linux only
  • a9b245b: 8269523: runtime/Safepoint/TestAbortOnVMOperationTimeout.java failed when expecting 'VM operation took too long'
  • e8b4d82: 8244602: Add JTREG_REPEAT_COUNT to repeat execution of a test
  • ab0ade6: 8272398: Update DockerTestUtils.buildJdkDockerImage()
  • db0b611: 8278384: Bytecodes::result_type() for arraylength returns T_VOID instead of T_INT
  • ... and 47 more: https://git.openjdk.java.net/jdk17u-dev/compare/5ea8f4835da08623c5c03983aab10382db2b95a5...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 11, 2022
@openjdk openjdk bot closed this Jan 11, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 11, 2022
@openjdk
Copy link

openjdk bot commented Jan 11, 2022

@RealCLanger @cushon Pushed as commit 75f8752.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

MattAlp added a commit to DataDog/openjdk-jdk17 that referenced this pull request Feb 26, 2025
MattAlp added a commit to DataDog/openjdk-jdk17 that referenced this pull request Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants