Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8313626: C2 crash due to unexpected exception control flow #1709

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Aug 30, 2023

Clean backport to fix C2 issue.

Additional testing:

  • New test fails without the patch, passes with it
  • Linux AArch64 tier1 tier2 tier3

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8313626: C2 crash due to unexpected exception control flow (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1709/head:pull/1709
$ git checkout pull/1709

Update a local copy of the PR:
$ git checkout pull/1709
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1709/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1709

View PR using the GUI difftool:
$ git pr show -t 1709

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1709.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 30, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f8203cb272e6136b784e5c43a500f6a0bfb19c8b 8313626: C2 crash due to unexpected exception control flow Aug 30, 2023
@openjdk
Copy link

openjdk bot commented Aug 30, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 30, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313626: C2 crash due to unexpected exception control flow

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 3681719: 8310233: Fix THP detection on Linux

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 30, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 30, 2023

Webrevs

@shipilev
Copy link
Member Author

Testing is clean. Push approval granted.

/integrate

@openjdk
Copy link

openjdk bot commented Aug 31, 2023

Going to push as commit 8d70429.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 7f3f76f: 8286430: make test TEST="gtest:" exits with error when it shouldn't
  • eb639a2: 8312585: Rename DisableTHPStackMitigation flag to THPStackMitigation
  • 804ce09: 8312620: WSL Linux build crashes after JDK-8310233
  • e0b39c7: 8312535: MidiSystem.getSoundbank() throws unexpected SecurityException
  • e6b87a7: 8312182: THPs cause huge RSS due to thread start timing issue
  • fbe3773: 8312394: [linux] SIGSEGV if kernel was built without hugepage support
  • 0d4fbb4: 8295229: Try to verify gtest version
  • 3681719: 8310233: Fix THP detection on Linux

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 31, 2023
@openjdk openjdk bot closed this Aug 31, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 31, 2023
@openjdk
Copy link

openjdk bot commented Aug 31, 2023

@shipilev Pushed as commit 8d70429.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8313626-c2-unexpected-control branch December 11, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant