8314495: Update to use jtreg 7.3.1#1712
Conversation
|
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
|
I don't really see the point of adding all the relevant "jtreg update" issues to this PR, but I can if anyone has a strong opinion about it. @GoeLin, @RealCLanger? |
|
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 8 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
No strong opinion, it's fine. |
|
Before I integrate, can I ask @TheRealMDoerr @RealCLanger or @GoeLin to run this through their nightly testing too? Don't want to break stuff if we can avoid it. |
|
We already use the new jtreg version for our nightly tests. I've put your PR into our queue. |
Ah, that would be enough then. I wanted to check if any test does not work with new jtreg, e.g. due to missing testbug backport. If your nightly already passes with 7.3.1, then we are already good. |
|
Test results look good. Your PR is appreciated! But, testing it does not harm. I'll keep it in the queue. |
Yes, we had already switched our testing of JDK 17 and later to 7.3.1 when we saw your PR (Thanks @ArnoZeller). Looks all fine, this PR is good to go from our end. |
|
All right then! Here goes. /integrate |
|
Going to push as commit 75e1441.
Your commit was automatically rebased without conflicts. |
Atomically brings jtreg 7.3.1 (current at mainline) to 17u. Depending on new jtreg allows to cleanly backport tests from mainline without rewriting them for older jtreg.
Thankfully, @GoeLin backported all the actual test changes that are needed for this to work.
The uncleanliness comes mostly from the gtest "version" variable conflicts. Otherwise the whole stack applies cleanly.
Additional testing:
tier1 tier2 tier3 tier4Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1712/head:pull/1712$ git checkout pull/1712Update a local copy of the PR:
$ git checkout pull/1712$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1712/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1712View PR using the GUI difftool:
$ git pr show -t 1712Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1712.diff
Webrev
Link to Webrev Comment