Skip to content

Conversation

@TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Aug 31, 2023

Backport of JDK-8314960.
Applies cleanly except:

  • I had to move the certificate due to JDK-8257733.
  • Hunks in VerifyCACerts.java are easy to resolve. I had to compute and insert the new CHECKSUM.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8314960: Add Certigna Root CA - 2 (Enhancement - P2)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1715/head:pull/1715
$ git checkout pull/1715

Update a local copy of the PR:
$ git checkout pull/1715
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1715/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1715

View PR using the GUI difftool:
$ git pr show -t 1715

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1715.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 31, 2023

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e9ba8d5a0e74c7e61f963b9a295662899d0156dd 8314960: Add Certigna Root CA - 2 Aug 31, 2023
@openjdk
Copy link

openjdk bot commented Aug 31, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Aug 31, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 31, 2023

Webrevs

@TheRealMDoerr
Copy link
Contributor Author

Too late. Please review openjdk/jdk17u#377 instead.

@TheRealMDoerr TheRealMDoerr deleted the 8314960_CertignaRootCA branch September 1, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant