Skip to content

8312625: Test serviceability/dcmd/vm/TrimLibcHeapTest.java failed: RSS use increased #1718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Sep 1, 2023

Hi all,

This pull request contains a backport of JDK-8312625, commit 117f42db from the openjdk/jdk repository.

The commit being backported was authored by Thomas Stuefe on 26 Jul 2023 and was reviewed by Kevin Walls and David Holmes.

It hopefully fixes an issue that intermittently shows in our CI.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • JDK-8312625 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8312625: Test serviceability/dcmd/vm/TrimLibcHeapTest.java failed: RSS use increased (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1718/head:pull/1718
$ git checkout pull/1718

Update a local copy of the PR:
$ git checkout pull/1718
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1718/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1718

View PR using the GUI difftool:
$ git pr show -t 1718

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1718.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 1, 2023

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 117f42dbe9a78bcf43bdf3873d5d86a19a9092d3 8312625: Test serviceability/dcmd/vm/TrimLibcHeapTest.java failed: RSS use increased Sep 1, 2023
@openjdk
Copy link

openjdk bot commented Sep 1, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 1, 2023

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312625: Test serviceability/dcmd/vm/TrimLibcHeapTest.java failed: RSS use increased

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • be34f0b: 8271886: mark hotspot runtime/InvocationTests tests which ignore external VM flags
  • bb2fcb8: 8314024: SIGSEGV in PhaseIdealLoop::build_loop_late_post_work due to bad immediate dominator info
  • 6b192d3: 8299677: Formatter.format might take a long time to format an integer or floating-point
  • caaf942: Merge
  • dc00ae4: 8299658: C1 compilation crashes in LinearScan::resolve_exception_edge
  • a44f8b0: 8314960: Add Certigna Root CA - 2
  • 75e1441: 8314495: Update to use jtreg 7.3.1
  • c4612c1: 8207166: jdk/jshell/JdiHangingLaunchExecutionControlTest.java - launch timeout
  • 5b613e3: 8312489: Increase jdk.jar.maxSignatureFileSize default which is too low for JARs such as WhiteSource/Mend unified agent jar

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 1, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 1, 2023

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Sep 11, 2023

/approve yes

@openjdk
Copy link

openjdk bot commented Sep 11, 2023

⚠️ @RealCLanger This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval and removed ready Pull request is ready to be integrated labels Sep 11, 2023
@openjdk
Copy link

openjdk bot commented Sep 11, 2023

@GoeLin
8312625: The approval request has been approved.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Sep 11, 2023
@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 13, 2023

Going to push as commit 45b6bca.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 4e9b6da: 8309032: jpackage does not work for module projects unless --module-path is specified
  • a5a3505: 8315549: CITime misreports code/total nmethod sizes
  • f8f4943: 8244289: fatal error: Possible safepoint reached by thread that does not allow it
  • be34f0b: 8271886: mark hotspot runtime/InvocationTests tests which ignore external VM flags
  • bb2fcb8: 8314024: SIGSEGV in PhaseIdealLoop::build_loop_late_post_work due to bad immediate dominator info
  • 6b192d3: 8299677: Formatter.format might take a long time to format an integer or floating-point
  • caaf942: Merge
  • dc00ae4: 8299658: C1 compilation crashes in LinearScan::resolve_exception_edge
  • a44f8b0: 8314960: Add Certigna Root CA - 2
  • 75e1441: 8314495: Update to use jtreg 7.3.1
  • ... and 2 more: https://git.openjdk.org/jdk17u-dev/compare/f85df30c92401376b060d769a5fb08844bbac3d4...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 13, 2023
@openjdk openjdk bot closed this Sep 13, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 13, 2023
@openjdk
Copy link

openjdk bot commented Sep 13, 2023

@RealCLanger Pushed as commit 45b6bca.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants