Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314935: Shenandoah: Unable to throw OOME on back-to-back Full GCs #1724

Closed

Conversation

earthling-amzn
Copy link

@earthling-amzn earthling-amzn commented Sep 7, 2023

Backport was unclean, but trivially resolved nullptr/NULL conflict.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8314935 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8314935: Shenandoah: Unable to throw OOME on back-to-back Full GCs (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1724/head:pull/1724
$ git checkout pull/1724

Update a local copy of the PR:
$ git checkout pull/1724
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1724/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1724

View PR using the GUI difftool:
$ git pr show -t 1724

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1724.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 7, 2023

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 716201c77d160dc78db61957aa002eef71641688 8314935: Shenandoah: Unable to throw OOME on back-to-back Full GCs Sep 7, 2023
@openjdk
Copy link

openjdk bot commented Sep 7, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Sep 7, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 7, 2023

Webrevs

@phohensee
Copy link
Member

Please backport to 21u as well.

@openjdk
Copy link

openjdk bot commented Sep 7, 2023

⚠️ @earthling-amzn This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@earthling-amzn
Copy link
Author

Please backport to 21u as well.

Will do.

@earthling-amzn
Copy link
Author

/approval

@openjdk
Copy link

openjdk bot commented Sep 8, 2023

@earthling-amzn usage: /approval [<id>] (request|cancel) [<text>]

@earthling-amzn
Copy link
Author

/approval request Unclean backport, but trivial nullptr/NULL conflict. Passed GHA, also Dacapo, SpecJBB, Extremem and Heapothesys.

@openjdk
Copy link

openjdk bot commented Sep 8, 2023

@earthling-amzn The approval request has been created successfully.

@openjdk openjdk bot added the approval label Sep 8, 2023
@GoeLin
Copy link
Member

GoeLin commented Sep 13, 2023

/approve yes

@openjdk
Copy link

openjdk bot commented Sep 13, 2023

@GoeLin
8314935: The approval request has been approved.

@openjdk
Copy link

openjdk bot commented Sep 13, 2023

@earthling-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314935: Shenandoah: Unable to throw OOME on back-to-back Full GCs

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 87 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Sep 13, 2023
@earthling-amzn
Copy link
Author

We are abandoning this backport in favor of openjdk/jdk#15852

@GoeLin
Copy link
Member

GoeLin commented Oct 17, 2023

I will remove the jdk17u-*-request labels to get the issue removed from the filters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport ready Pull request is ready to be integrated rfr Pull request is ready for review
3 participants