Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8244289: fatal error: Possible safepoint reached by thread that does not allow it #1726

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Sep 8, 2023

Clean backport to improve JFR reliability.

Additional testing:

  • macos-aarch64-server-fastdebug, jdk/jfr

Progress

  • Change must not contain extraneous whitespace
  • JDK-8244289 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8244289: fatal error: Possible safepoint reached by thread that does not allow it (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1726/head:pull/1726
$ git checkout pull/1726

Update a local copy of the PR:
$ git checkout pull/1726
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1726/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1726

View PR using the GUI difftool:
$ git pr show -t 1726

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1726.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 8, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 61932f49a58b73530e89e511874fbe2fbc343e99 8244289: fatal error: Possible safepoint reached by thread that does not allow it Sep 8, 2023
@openjdk
Copy link

openjdk bot commented Sep 8, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 8, 2023

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 8, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 8, 2023

Webrevs

@openjdk openjdk bot added the approval label Sep 8, 2023
@GoeLin
Copy link
Member

GoeLin commented Sep 11, 2023

/approve yes

@openjdk
Copy link

openjdk bot commented Sep 11, 2023

@GoeLin
8244289: The approval request has been approved.

@openjdk
Copy link

openjdk bot commented Sep 11, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8244289: fatal error: Possible safepoint reached by thread that does not allow it

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

  • be34f0b: 8271886: mark hotspot runtime/InvocationTests tests which ignore external VM flags
  • bb2fcb8: 8314024: SIGSEGV in PhaseIdealLoop::build_loop_late_post_work due to bad immediate dominator info
  • 6b192d3: 8299677: Formatter.format might take a long time to format an integer or floating-point
  • caaf942: Merge
  • dc00ae4: 8299658: C1 compilation crashes in LinearScan::resolve_exception_edge
  • a44f8b0: 8314960: Add Certigna Root CA - 2
  • 75e1441: 8314495: Update to use jtreg 7.3.1
  • c4612c1: 8207166: jdk/jshell/JdiHangingLaunchExecutionControlTest.java - launch timeout
  • 5b613e3: 8312489: Increase jdk.jar.maxSignatureFileSize default which is too low for JARs such as WhiteSource/Mend unified agent jar
  • f85df30: 8314139: TEST_BUG: runtime/os/THPsInThreadStackPreventionTest.java could fail on machine with large number of cores
  • ... and 7 more: https://git.openjdk.org/jdk17u-dev/compare/0d4fbb460d8ed6bb2695cbaad8a345dfe4d6b005...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Sep 11, 2023
@shipilev
Copy link
Member Author

Push approval granted.

/integrate

@openjdk
Copy link

openjdk bot commented Sep 11, 2023

Going to push as commit f8f4943.
Since your change was applied there have been 17 commits pushed to the master branch:

  • be34f0b: 8271886: mark hotspot runtime/InvocationTests tests which ignore external VM flags
  • bb2fcb8: 8314024: SIGSEGV in PhaseIdealLoop::build_loop_late_post_work due to bad immediate dominator info
  • 6b192d3: 8299677: Formatter.format might take a long time to format an integer or floating-point
  • caaf942: Merge
  • dc00ae4: 8299658: C1 compilation crashes in LinearScan::resolve_exception_edge
  • a44f8b0: 8314960: Add Certigna Root CA - 2
  • 75e1441: 8314495: Update to use jtreg 7.3.1
  • c4612c1: 8207166: jdk/jshell/JdiHangingLaunchExecutionControlTest.java - launch timeout
  • 5b613e3: 8312489: Increase jdk.jar.maxSignatureFileSize default which is too low for JARs such as WhiteSource/Mend unified agent jar
  • f85df30: 8314139: TEST_BUG: runtime/os/THPsInThreadStackPreventionTest.java could fail on machine with large number of cores
  • ... and 7 more: https://git.openjdk.org/jdk17u-dev/compare/0d4fbb460d8ed6bb2695cbaad8a345dfe4d6b005...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 11, 2023
@openjdk openjdk bot closed this Sep 11, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 11, 2023
@openjdk
Copy link

openjdk bot commented Sep 11, 2023

@shipilev Pushed as commit f8f4943.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8244289-jfr-bad-locking branch December 11, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants