-
Notifications
You must be signed in to change notification settings - Fork 224
8276711: compiler/codecache/cli tests failing when SegmentedCodeCache used with -Xint #1728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back eastigeevich! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
/approval |
@eastig usage: |
/approval request Prevents allocation of the non-profiled code heap in the interpreter-only mode. Applies cleanly. Tests pass. |
/approve yes |
@RealCLanger |
@eastig This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
/sponsor |
@eastig Only Committers are allowed to sponsor changes. |
/sponsor |
Going to push as commit 444f829.
Your commit was automatically rebased without conflicts. |
@TheRealMDoerr @eastig Pushed as commit 444f829. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Clean backport to have a non-segmented CodeCache for JVM running with
-XX:TieredStopAtLevel=0 -XX:+SegmentedCodeCache
. The fix has been in mainline for 1.5 years.Risks are low: the fix prevents the allocation of the non-profiled code heap which is not used in the interpreter-only mode.
Additional testing:
tier1
tier2
tier3
tier1
tier2
tier3
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1728/head:pull/1728
$ git checkout pull/1728
Update a local copy of the PR:
$ git checkout pull/1728
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1728/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1728
View PR using the GUI difftool:
$ git pr show -t 1728
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1728.diff
Webrev
Link to Webrev Comment