Skip to content

8276711: compiler/codecache/cli tests failing when SegmentedCodeCache used with -Xint #1728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

eastig
Copy link
Member

@eastig eastig commented Sep 12, 2023

Clean backport to have a non-segmented CodeCache for JVM running with -XX:TieredStopAtLevel=0 -XX:+SegmentedCodeCache. The fix has been in mainline for 1.5 years.
Risks are low: the fix prevents the allocation of the non-profiled code heap which is not used in the interpreter-only mode.

Additional testing:

  • Linux x86_64 fastdebug: tier1
  • Linux x86_64 fastdebug: tier2
  • Linux x86_64 fastdebug: tier3
  • Linux AArch64 fastdebug: tier1
  • Linux AArch64 fastdebug: tier2
  • Linux AArch64 fastdebug: tier3

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8276711 needs maintainer approval

Issue

  • JDK-8276711: compiler/codecache/cli tests failing when SegmentedCodeCache used with -Xint (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1728/head:pull/1728
$ git checkout pull/1728

Update a local copy of the PR:
$ git checkout pull/1728
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1728/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1728

View PR using the GUI difftool:
$ git pr show -t 1728

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1728.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 12, 2023

👋 Welcome back eastigeevich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7822cbce10e0c0c6f9bf521faebc89a0af20734e 8276711: compiler/codecache/cli tests failing when SegmentedCodeCache used with -Xint Sep 12, 2023
@openjdk
Copy link

openjdk bot commented Sep 12, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 12, 2023

⚠️ @eastig This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 12, 2023
@eastig
Copy link
Member Author

eastig commented Sep 12, 2023

/approval

@openjdk
Copy link

openjdk bot commented Sep 12, 2023

@eastig usage: /approval [<id>] (request|cancel) [<text>]

@mlbridge
Copy link

mlbridge bot commented Sep 12, 2023

Webrevs

@eastig
Copy link
Member Author

eastig commented Sep 12, 2023

/approval request Prevents allocation of the non-profiled code heap in the interpreter-only mode. Applies cleanly. Tests pass.

@openjdk
Copy link

openjdk bot commented Sep 12, 2023

@eastig The approval request has been created successfully.

@openjdk openjdk bot added the approval label Sep 12, 2023
@RealCLanger
Copy link
Contributor

/approve yes

@openjdk
Copy link

openjdk bot commented Sep 13, 2023

@RealCLanger
8276711: The approval request has been approved.

@openjdk
Copy link

openjdk bot commented Sep 13, 2023

@eastig This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276711: compiler/codecache/cli tests failing when SegmentedCodeCache used with -Xint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 45b6bca: 8312625: Test serviceability/dcmd/vm/TrimLibcHeapTest.java failed: RSS use increased
  • 4e9b6da: 8309032: jpackage does not work for module projects unless --module-path is specified
  • a5a3505: 8315549: CITime misreports code/total nmethod sizes
  • f8f4943: 8244289: fatal error: Possible safepoint reached by thread that does not allow it

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Sep 13, 2023
@eastig
Copy link
Member Author

eastig commented Sep 13, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 13, 2023
@openjdk
Copy link

openjdk bot commented Sep 13, 2023

@eastig
Your change (at version 97de055) is now ready to be sponsored by a Committer.

@eastig
Copy link
Member Author

eastig commented Sep 13, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 13, 2023

@eastig Only Committers are allowed to sponsor changes.

@TheRealMDoerr
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 13, 2023

Going to push as commit 444f829.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 45b6bca: 8312625: Test serviceability/dcmd/vm/TrimLibcHeapTest.java failed: RSS use increased
  • 4e9b6da: 8309032: jpackage does not work for module projects unless --module-path is specified
  • a5a3505: 8315549: CITime misreports code/total nmethod sizes
  • f8f4943: 8244289: fatal error: Possible safepoint reached by thread that does not allow it

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 13, 2023
@openjdk openjdk bot closed this Sep 13, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 13, 2023
@openjdk openjdk bot removed the sponsor Pull request is ready to be sponsored label Sep 13, 2023
@openjdk
Copy link

openjdk bot commented Sep 13, 2023

@TheRealMDoerr @eastig Pushed as commit 444f829.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants