Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8312573: Failure during CompileOnly parsing leads to ShouldNotReachHere #1735

Closed
wants to merge 2 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Sep 13, 2023

I backport this for parity with 17.0.10-oracle.

I had to resolve because of NULL/nulptr differences.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8312573 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8312573: Failure during CompileOnly parsing leads to ShouldNotReachHere (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1735/head:pull/1735
$ git checkout pull/1735

Update a local copy of the PR:
$ git checkout pull/1735
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1735/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1735

View PR using the GUI difftool:
$ git pr show -t 1735

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1735.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 13, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6f76b65ace50b2361221dddab120e91b057497c1 8312573: Failure during CompileOnly parsing leads to ShouldNotReachHere Sep 13, 2023
@openjdk
Copy link

openjdk bot commented Sep 13, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Sep 13, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 13, 2023

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test is missing, plus nullptr is used. Something went wrong. :)

@GoeLin
Copy link
Member Author

GoeLin commented Sep 14, 2023

Hi Paul, thanks for spotting this. I added the test.
Using nullptr is not an issue, it is used in many places in 17, it is only that the occurance of NULL spoils the patching.

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@openjdk
Copy link

openjdk bot commented Sep 14, 2023

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval label Sep 15, 2023
@openjdk
Copy link

openjdk bot commented Sep 15, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312573: Failure during CompileOnly parsing leads to ShouldNotReachHere

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 4d8549b: 8299255: Unexpected round errors in FreetypeFontScaler
  • af9d522: 8232933: Javac inferred type does not conform to equality constraint
  • 4636018: 8315020: The macro definition for LoongArch64 zero build is not accurate.
  • 47f8718: 8314094: java/lang/ProcessHandle/InfoTest.java fails on Windows when run as user with Administrator privileges
  • 0ddf1eb: 8315751: RandomTestBsi1999 fails often with timeouts on Linux ppc64le
  • cc9a8e9: 8301701: java/net/DatagramSocket/DatagramSocketMulticasting.java should be hardened
  • 4ac28fc: 8285516: clearPassword should be called in a finally try block
  • 444f829: 8276711: compiler/codecache/cli tests failing when SegmentedCodeCache used with -Xint
  • 45b6bca: 8312625: Test serviceability/dcmd/vm/TrimLibcHeapTest.java failed: RSS use increased

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Sep 15, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Sep 15, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Sep 15, 2023

Going to push as commit 955dcb3.
Since your change was applied there have been 12 commits pushed to the master branch:

  • bc7699a: 8304954: SegmentedCodeCache fails when using large pages
  • e12d0b5: 8311592: ECKeySizeParameterSpec causes too many exceptions on third party providers
  • 35cf71f: 8301065: Handle control characters in java_lang_String::print
  • 4d8549b: 8299255: Unexpected round errors in FreetypeFontScaler
  • af9d522: 8232933: Javac inferred type does not conform to equality constraint
  • 4636018: 8315020: The macro definition for LoongArch64 zero build is not accurate.
  • 47f8718: 8314094: java/lang/ProcessHandle/InfoTest.java fails on Windows when run as user with Administrator privileges
  • 0ddf1eb: 8315751: RandomTestBsi1999 fails often with timeouts on Linux ppc64le
  • cc9a8e9: 8301701: java/net/DatagramSocket/DatagramSocketMulticasting.java should be hardened
  • 4ac28fc: 8285516: clearPassword should be called in a finally try block
  • ... and 2 more: https://git.openjdk.org/jdk17u-dev/compare/4e9b6da251b620a488334061451c59c36703f7ec...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 15, 2023
@openjdk openjdk bot closed this Sep 15, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 15, 2023
@openjdk
Copy link

openjdk bot commented Sep 15, 2023

@GoeLin Pushed as commit 955dcb3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8312573 branch September 15, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants