Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8311514: Incorrect regex in TestMetaSpaceLog.java #1737

Closed
wants to merge 1 commit into from

Conversation

elifaslan1
Copy link
Contributor

@elifaslan1 elifaslan1 commented Sep 13, 2023

Clean backport to fix the regex in jtreg test TestMetaSpaceLog.java capturing wrong value which might cause this test to always pass.

JDK-8311514Incorrect regex in TestMetaSpaceLog.java

Tested with GHA


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8311514 needs maintainer approval

Issue

  • JDK-8311514: Incorrect regex in TestMetaSpaceLog.java (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1737/head:pull/1737
$ git checkout pull/1737

Update a local copy of the PR:
$ git checkout pull/1737
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1737/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1737

View PR using the GUI difftool:
$ git pr show -t 1737

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1737.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 13, 2023

👋 Welcome back elifaslan1! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9084b6c9d5b6550059fee39d6335fed467f1c45c 8311514: Incorrect regex in TestMetaSpaceLog.java Sep 13, 2023
@openjdk
Copy link

openjdk bot commented Sep 13, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 13, 2023

⚠️ @elifaslan1 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 13, 2023
@openjdk
Copy link

openjdk bot commented Sep 13, 2023

@elifaslan1 usage: /approval [<id>] (request|cancel) [<text>]

@mlbridge
Copy link

mlbridge bot commented Sep 13, 2023

Webrevs

@elifaslan1
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 13, 2023

@elifaslan1 This pull request has not yet been marked as ready for integration.

@elifaslan1
Copy link
Contributor Author

/approval request

@openjdk
Copy link

openjdk bot commented Sep 13, 2023

@elifaslan1 The approval request has been created successfully.

@openjdk openjdk bot added the approval label Sep 13, 2023
@GoeLin
Copy link
Member

GoeLin commented Sep 15, 2023

Hi @elifaslan1, please supply a correct Fix request comment in the JBS bug.
You can do this by specifying a text in the approval command, or by editing the JBS issue.
State reason, risk, and testing in that comment.

@GoeLin
Copy link
Member

GoeLin commented Sep 19, 2023

Hi @elifaslan1, please supply a correct Fix request comment in the JBS bug.
You can do this by specifying a text in the approval command, or by editing the JBS issue.
State reason, risk, and testing in that comment.

You can issue the approve command a second time with a comment! I remove the tag for now.

@openjdk openjdk bot removed the approval label Sep 19, 2023
@elifaslan1
Copy link
Contributor Author

/approval JDK-8311514 request “Clean backport. Fix a jtreg test for capturing wrong value. Low risk. GHA tested”

@openjdk
Copy link

openjdk bot commented Sep 19, 2023

@elifaslan1 The approval request has been updated successfully.

@openjdk openjdk bot added the approval label Sep 19, 2023
@GoeLin
Copy link
Member

GoeLin commented Sep 20, 2023

/approve yes

@openjdk
Copy link

openjdk bot commented Sep 20, 2023

@GoeLin
8311514: The approval request has been approved.

@openjdk
Copy link

openjdk bot commented Sep 20, 2023

@elifaslan1 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311514: Incorrect regex in TestMetaSpaceLog.java

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

  • ac2d89b: 8311813: C1: Uninitialized PhiResolver::_loop field
  • 05964ff: 8315863: [GHA] Update checkout action to use v4
  • 875d24b: Merge
  • a831b7a: 8312555: Ideographic characters aren't stretched by AffineTransform.scale(2, 1)
  • a06047a: 8168469: Memory leak in JceSecurity
  • 1a68e52: 8314679: SA fails to properly attach to JVM after having just detached from a different JVM
  • 7588666: 8313657: com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors
  • a3e8026: 8294427: Check boxes and radio buttons have rendering issues on Windows in High DPI env
  • d2045f9: 8265586: [windows] last button is not shown in AWT Frame with BorderLayout and MenuBar set.
  • f3ee6ea: 8061729: Update java/net tests to eliminate dependency on sun.net.www.MessageHeader and some other internal APIs
  • ... and 17 more: https://git.openjdk.org/jdk17u-dev/compare/4e9b6da251b620a488334061451c59c36703f7ec...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Sep 20, 2023
@elifaslan1
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 20, 2023
@openjdk
Copy link

openjdk bot commented Sep 20, 2023

@elifaslan1
Your change (at version 8f6fcc3) is now ready to be sponsored by a Committer.

@Rudometov
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 20, 2023

Going to push as commit 4ebd8b3.
Since your change was applied there have been 27 commits pushed to the master branch:

  • ac2d89b: 8311813: C1: Uninitialized PhiResolver::_loop field
  • 05964ff: 8315863: [GHA] Update checkout action to use v4
  • 875d24b: Merge
  • a831b7a: 8312555: Ideographic characters aren't stretched by AffineTransform.scale(2, 1)
  • a06047a: 8168469: Memory leak in JceSecurity
  • 1a68e52: 8314679: SA fails to properly attach to JVM after having just detached from a different JVM
  • 7588666: 8313657: com.sun.jndi.ldap.Connection.cleanup does not close connections on SocketTimeoutErrors
  • a3e8026: 8294427: Check boxes and radio buttons have rendering issues on Windows in High DPI env
  • d2045f9: 8265586: [windows] last button is not shown in AWT Frame with BorderLayout and MenuBar set.
  • f3ee6ea: 8061729: Update java/net tests to eliminate dependency on sun.net.www.MessageHeader and some other internal APIs
  • ... and 17 more: https://git.openjdk.org/jdk17u-dev/compare/4e9b6da251b620a488334061451c59c36703f7ec...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 20, 2023
@openjdk openjdk bot closed this Sep 20, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 20, 2023
@openjdk
Copy link

openjdk bot commented Sep 20, 2023

@Rudometov @elifaslan1 Pushed as commit 4ebd8b3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@elifaslan1 elifaslan1 deleted the JDK-8311514 branch November 1, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
3 participants