Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265586: [windows] last button is not shown in AWT Frame with BorderLayout and MenuBar set. #1743

Closed
wants to merge 2 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Sep 15, 2023

I backport this for parity with 17.0.10-oracle.

I include the follow-up bug fix for convenience.
Both patches applied clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8288993 needs maintainer approval
  • JDK-8265586 needs maintainer approval

Issues

  • JDK-8265586: [windows] last button is not shown in AWT Frame with BorderLayout and MenuBar set. (Bug - P4 - Approved)
  • JDK-8288993: Make AwtFramePackTest generic by removing @requires tag (Bug - P5 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1743/head:pull/1743
$ git checkout pull/1743

Update a local copy of the PR:
$ git checkout pull/1743
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1743/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1743

View PR using the GUI difftool:
$ git pr show -t 1743

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1743.diff

Webrev

Link to Webrev Comment

@GoeLin
Copy link
Member Author

GoeLin commented Sep 15, 2023

/issue JDK-8288993

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 15, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport bbaeacb597a8acc2c88793a6231c53ea0453f4d4 8265586: [windows] last button is not shown in AWT Frame with BorderLayout and MenuBar set. Sep 15, 2023
@openjdk
Copy link

openjdk bot commented Sep 15, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Sep 15, 2023
@openjdk
Copy link

openjdk bot commented Sep 15, 2023

@GoeLin
Adding additional issue to issue list: 8288993: Make AwtFramePackTest generic by removing @requires tag.

@mlbridge
Copy link

mlbridge bot commented Sep 15, 2023

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Sep 19, 2023

/clean

Composition of two clean patches. Verified.

@openjdk
Copy link

openjdk bot commented Sep 19, 2023

@GoeLin This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Sep 19, 2023

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk
Copy link

openjdk bot commented Sep 20, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265586: [windows] last button is not shown in AWT Frame with BorderLayout and MenuBar set.
8288993: Make AwtFramePackTest generic by removing @requires tag

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 1ce12c4: 8312065: Socket.connect does not timeout when profiling
  • fee0229: 8312909: C1 should not inline through interface calls with non-subtype receiver
  • 955dcb3: 8312573: Failure during CompileOnly parsing leads to ShouldNotReachHere
  • bc7699a: 8304954: SegmentedCodeCache fails when using large pages
  • e12d0b5: 8311592: ECKeySizeParameterSpec causes too many exceptions on third party providers
  • 35cf71f: 8301065: Handle control characters in java_lang_String::print
  • 4d8549b: 8299255: Unexpected round errors in FreetypeFontScaler
  • af9d522: 8232933: Javac inferred type does not conform to equality constraint
  • 4636018: 8315020: The macro definition for LoongArch64 zero build is not accurate.
  • 47f8718: 8314094: java/lang/ProcessHandle/InfoTest.java fails on Windows when run as user with Administrator privileges

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Sep 20, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Sep 20, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Sep 20, 2023

Going to push as commit d2045f9.
Since your change was applied there have been 13 commits pushed to the master branch:

  • f3ee6ea: 8061729: Update java/net tests to eliminate dependency on sun.net.www.MessageHeader and some other internal APIs
  • f908cee: 8270447: [IR Framework] Add missing compilation level restriction when using FlipC1C2 stress option
  • be52dc5: 8247351: [aarch64] NullPointerException during stack walking (clhsdb "where -a")
  • 1ce12c4: 8312065: Socket.connect does not timeout when profiling
  • fee0229: 8312909: C1 should not inline through interface calls with non-subtype receiver
  • 955dcb3: 8312573: Failure during CompileOnly parsing leads to ShouldNotReachHere
  • bc7699a: 8304954: SegmentedCodeCache fails when using large pages
  • e12d0b5: 8311592: ECKeySizeParameterSpec causes too many exceptions on third party providers
  • 35cf71f: 8301065: Handle control characters in java_lang_String::print
  • 4d8549b: 8299255: Unexpected round errors in FreetypeFontScaler
  • ... and 3 more: https://git.openjdk.org/jdk17u-dev/compare/0ddf1ebe3df119be2029b12feee93d0128e7cae0...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 20, 2023
@openjdk openjdk bot closed this Sep 20, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 20, 2023
@openjdk
Copy link

openjdk bot commented Sep 20, 2023

@GoeLin Pushed as commit d2045f9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8265586 branch September 20, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant