8293579: tools/jpackage/share/jdk/jpackage/tests/UnicodeArgsTest.java fails on Japanese Windows platform

[masyano]

Hi all,

This pull request contains a backport of commit 121d4a51 from the openjdk/jdk repository.

The commit being backported was authored by KIRIYAMA Takuya on 4 Oct 2022 and was reviewed by Alexey Semenyuk, Naoto Sato and Alexander Matveev.

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8293579 needs maintainer approval

Issue

• JDK-8293579: tools/jpackage/share/jdk/jpackage/tests/UnicodeArgsTest.java fails on Japanese Windows platform (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1745/head:pull/1745
$ git checkout pull/1745

Update a local copy of the PR:
$ git checkout pull/1745
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1745/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1745

View PR using the GUI difftool:
$ git pr show -t 1745

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1745.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back myano! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @masyano This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (4660435f)

[RealCLanger]

/approve yes

[openjdk]

@RealCLanger
8293579: The approval request has been approved.

[openjdk]

@masyano This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293579: tools/jpackage/share/jdk/jpackage/tests/UnicodeArgsTest.java fails on Japanese Windows platform

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 35 new commits pushed to the master branch:

• d6eec8d: 8276036: The value of full_count in the message of insufficient codecache is wrong
• 93071dc: 8316178: Better diagnostic header for CodeBlobs
• 125ae25: 8314045: ArithmeticException in GaloisCounterMode
• 0e02204: 8314263: Signed jars triggering Logger finder recursion and StackOverflowError
• 069743d: 8292636: (dc) Problem listing of java/nio/channels/DatagramChannel/Unref.java has incorrect issue ID
• d6b1106: 8193543: Regression automated test '/open/test/jdk/java/awt/TrayIcon/SystemTrayInstance/SystemTrayInstanceTest.java' fails
• 27c114f: 8271891: mark hotspot runtime/Safepoint tests which ignore external VM flags
• 3baaf7c: 8271890: mark hotspot runtime/Dictionary tests which ignore external VM flags
• 1eac8a4: 8271824: mark hotspot runtime/CompressedOops tests which ignore external VM flags
• 43ad5d2: 8314063: The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection
• ... and 25 more: https://git.openjdk.org/jdk17u-dev/compare/0ddf1ebe3df119be2029b12feee93d0128e7cae0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[masyano]

/integrate

[openjdk]

@masyano
Your change (at version 4660435) is now ready to be sponsored by a Committer.

[RealCLanger]

/sponsor

[openjdk]

Going to push as commit 93211bd.
Since your change was applied there have been 35 commits pushed to the master branch:

• d6eec8d: 8276036: The value of full_count in the message of insufficient codecache is wrong
• 93071dc: 8316178: Better diagnostic header for CodeBlobs
• 125ae25: 8314045: ArithmeticException in GaloisCounterMode
• 0e02204: 8314263: Signed jars triggering Logger finder recursion and StackOverflowError
• 069743d: 8292636: (dc) Problem listing of java/nio/channels/DatagramChannel/Unref.java has incorrect issue ID
• d6b1106: 8193543: Regression automated test '/open/test/jdk/java/awt/TrayIcon/SystemTrayInstance/SystemTrayInstanceTest.java' fails
• 27c114f: 8271891: mark hotspot runtime/Safepoint tests which ignore external VM flags
• 3baaf7c: 8271890: mark hotspot runtime/Dictionary tests which ignore external VM flags
• 1eac8a4: 8271824: mark hotspot runtime/CompressedOops tests which ignore external VM flags
• 43ad5d2: 8314063: The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection
• ... and 25 more: https://git.openjdk.org/jdk17u-dev/compare/0ddf1ebe3df119be2029b12feee93d0128e7cae0...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealCLanger @masyano Pushed as commit 93211bd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.