Skip to content

8279669: test/jdk/com/sun/jdi/TestScaffold.java uses wrong condition #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

zzambers
Copy link
Contributor

@zzambers zzambers commented Feb 23, 2022

Tested locally test/jdk/com/sun/jdi tests passed for me.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8279669: test/jdk/com/sun/jdi/TestScaffold.java uses wrong condition

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/175/head:pull/175
$ git checkout pull/175

Update a local copy of the PR:
$ git checkout pull/175
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/175/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 175

View PR using the GUI difftool:
$ git pr show -t 175

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/175.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 23, 2022

👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 4c52eb39431c2479b0d140907bdcc0311d30f871 8279669: test/jdk/com/sun/jdi/TestScaffold.java uses wrong condition Feb 23, 2022
@openjdk
Copy link

openjdk bot commented Feb 23, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 23, 2022

@zzambers This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279669: test/jdk/com/sun/jdi/TestScaffold.java uses wrong condition

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 23, 2022
@zzambers
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 23, 2022
@openjdk
Copy link

openjdk bot commented Feb 23, 2022

@zzambers
Your change (at version 9492b21) is now ready to be sponsored by a Committer.

@mlbridge
Copy link

mlbridge bot commented Feb 23, 2022

Webrevs

@zzambers
Copy link
Contributor Author

sorry, integrate command was a mistake as it needs approval for jdk17u (I got confused about the process)

@jerboaa
Copy link
Contributor

jerboaa commented Feb 28, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 28, 2022

Going to push as commit c2a62d7.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 9e9c150: 8276841: Add support for Visual Studio 2022
  • 90d83a2: 8272866: java.util.random package summary contains incorrect mixing function in table
  • fc57ee6: 8272996: JNDI DNS provider fails to resolve SRV entries when IPV6 stack is enabled
  • df5a29c: 8278185: Custom JRE cannot find non-ASCII named module inside
  • 6650652: 8281460: Let ObjectMonitor have its own NMT category
  • 56f0c53: 8278163: --with-cacerts-src variable resolved after GenerateCacerts recipe setup
  • 0c6e662: 8277383: VM.metaspace optionally show chunk freelist details
  • 9bb8b7f: 8271721: Split gc/g1/TestMixedGCLiveThreshold into separate tests

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 28, 2022
@openjdk openjdk bot closed this Feb 28, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 28, 2022
@openjdk
Copy link

openjdk bot commented Feb 28, 2022

@jerboaa @zzambers Pushed as commit c2a62d7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants