Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8061729: Update java/net tests to eliminate dependency on sun.net.www.MessageHeader and some other internal APIs #1750

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Sep 18, 2023

I backport this for parity with 17.0.10-oracle.

I include follow-up 8282017, of which I dropped the ProblemList change.
The test is not problem-listed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8061729 needs maintainer approval
  • JDK-8282017 needs maintainer approval

Issues

  • JDK-8061729: Update java/net tests to eliminate dependency on sun.net.www.MessageHeader and some other internal APIs (Bug - P4 - Approved)
  • JDK-8282017: sun/net/www/protocol/https/HttpsURLConnection/B6216082.java fails with "SocketException: Unexpected end of file from server" (Bug - P2 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1750/head:pull/1750
$ git checkout pull/1750

Update a local copy of the PR:
$ git checkout pull/1750
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1750/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1750

View PR using the GUI difftool:
$ git pr show -t 1750

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1750.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 18, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@GoeLin
Copy link
Member Author

GoeLin commented Sep 18, 2023

/issue JDK-8282017

@openjdk openjdk bot changed the title Backport 0f3d3ac32c9d163a5d91c6839d313111c72f1ad4 8061729: Update java/net tests to eliminate dependency on sun.net.www.MessageHeader and some other internal APIs Sep 18, 2023
@openjdk
Copy link

openjdk bot commented Sep 18, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Sep 18, 2023
@openjdk
Copy link

openjdk bot commented Sep 18, 2023

@GoeLin
Adding additional issue to issue list: 8282017: sun/net/www/protocol/https/HttpsURLConnection/B6216082.java fails with "SocketException: Unexpected end of file from server".

@mlbridge
Copy link

mlbridge bot commented Sep 18, 2023

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Sep 19, 2023

/clean

Composition of clean patches, trivial omit of ProblemList change. Verified.

@openjdk
Copy link

openjdk bot commented Sep 19, 2023

@GoeLin This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Sep 19, 2023

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk
Copy link

openjdk bot commented Sep 19, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8061729: Update java/net tests to eliminate dependency on sun.net.www.MessageHeader and some other internal APIs
8282017: sun/net/www/protocol/https/HttpsURLConnection/B6216082.java fails with "SocketException: Unexpected end of file from server"

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Sep 19, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Sep 20, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Sep 20, 2023

Going to push as commit f3ee6ea.
Since your change was applied there have been 2 commits pushed to the master branch:

  • f908cee: 8270447: [IR Framework] Add missing compilation level restriction when using FlipC1C2 stress option
  • be52dc5: 8247351: [aarch64] NullPointerException during stack walking (clhsdb "where -a")

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 20, 2023
@openjdk openjdk bot closed this Sep 20, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 20, 2023
@openjdk
Copy link

openjdk bot commented Sep 20, 2023

@GoeLin Pushed as commit f3ee6ea.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8061729 branch September 20, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant