8316178: Better diagnostic header for CodeBlobs#1759
8316178: Better diagnostic header for CodeBlobs#1759shipilev wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
|
/approval request Clean diagnostic patch, low-risk; better JMH perfasm profiling in the near future. |
|
/approve yes |
|
@GoeLin |
|
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 30 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
Push approval granted. /integrate |
|
Going to push as commit 93071dc.
Your commit was automatically rebased without conflicts. |
Semi-clean backport to improve JVM diagnostics. The surrounding lines are a bit different, that is why the patch does not apply cleanly.
Additional testing:
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1759/head:pull/1759$ git checkout pull/1759Update a local copy of the PR:
$ git checkout pull/1759$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1759/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1759View PR using the GUI difftool:
$ git pr show -t 1759Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1759.diff
Webrev
Link to Webrev Comment