Skip to content

8316178: Better diagnostic header for CodeBlobs#1759

Closed
shipilev wants to merge 1 commit intoopenjdk:masterfrom
shipilev:JDK-8316178-better-header-codeblobs
Closed

8316178: Better diagnostic header for CodeBlobs#1759
shipilev wants to merge 1 commit intoopenjdk:masterfrom
shipilev:JDK-8316178-better-header-codeblobs

Conversation

@shipilev
Copy link
Member

@shipilev shipilev commented Sep 21, 2023

Semi-clean backport to improve JVM diagnostics. The surrounding lines are a bit different, that is why the patch does not apply cleanly.

Additional testing:

  • Eyeballing JVM output

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8316178 needs maintainer approval

Issue

  • JDK-8316178: Better diagnostic header for CodeBlobs (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1759/head:pull/1759
$ git checkout pull/1759

Update a local copy of the PR:
$ git checkout pull/1759
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1759/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1759

View PR using the GUI difftool:
$ git pr show -t 1759

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1759.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 21, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d575968b4bde74bd557cb84e89f0fa0f96b04087 8316178: Better diagnostic header for CodeBlobs Sep 21, 2023
@openjdk
Copy link

openjdk bot commented Sep 21, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Sep 21, 2023
@openjdk
Copy link

openjdk bot commented Sep 21, 2023

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 21, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 21, 2023

Webrevs

@shipilev
Copy link
Member Author

/approval request Clean diagnostic patch, low-risk; better JMH perfasm profiling in the near future.

@openjdk
Copy link

openjdk bot commented Sep 21, 2023

@shipilev The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Sep 21, 2023
@GoeLin
Copy link
Member

GoeLin commented Sep 21, 2023

/approve yes

@openjdk
Copy link

openjdk bot commented Sep 21, 2023

@GoeLin
8316178: The approval request has been approved.

@openjdk
Copy link

openjdk bot commented Sep 21, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316178: Better diagnostic header for CodeBlobs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

  • 0e02204: 8314263: Signed jars triggering Logger finder recursion and StackOverflowError
  • 069743d: 8292636: (dc) Problem listing of java/nio/channels/DatagramChannel/Unref.java has incorrect issue ID
  • d6b1106: 8193543: Regression automated test '/open/test/jdk/java/awt/TrayIcon/SystemTrayInstance/SystemTrayInstanceTest.java' fails
  • 27c114f: 8271891: mark hotspot runtime/Safepoint tests which ignore external VM flags
  • 3baaf7c: 8271890: mark hotspot runtime/Dictionary tests which ignore external VM flags
  • 1eac8a4: 8271824: mark hotspot runtime/CompressedOops tests which ignore external VM flags
  • 43ad5d2: 8314063: The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection
  • 06756c4: 8288325: [windows] Actual and Preferred Size of AWT Non-resizable frame are different
  • 6398e46: 8273522: Rename test property vm.cds.archived.java.heap to vm.cds.write.archived.java.heap
  • 4ebd8b3: 8311514: Incorrect regex in TestMetaSpaceLog.java
  • ... and 20 more: https://git.openjdk.org/jdk17u-dev/compare/4636018f02f68ff4e0347969077bc80ed26ce847...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Sep 21, 2023
@shipilev
Copy link
Member Author

Push approval granted.

/integrate

@openjdk
Copy link

openjdk bot commented Sep 22, 2023

Going to push as commit 93071dc.
Since your change was applied there have been 31 commits pushed to the master branch:

  • 125ae25: 8314045: ArithmeticException in GaloisCounterMode
  • 0e02204: 8314263: Signed jars triggering Logger finder recursion and StackOverflowError
  • 069743d: 8292636: (dc) Problem listing of java/nio/channels/DatagramChannel/Unref.java has incorrect issue ID
  • d6b1106: 8193543: Regression automated test '/open/test/jdk/java/awt/TrayIcon/SystemTrayInstance/SystemTrayInstanceTest.java' fails
  • 27c114f: 8271891: mark hotspot runtime/Safepoint tests which ignore external VM flags
  • 3baaf7c: 8271890: mark hotspot runtime/Dictionary tests which ignore external VM flags
  • 1eac8a4: 8271824: mark hotspot runtime/CompressedOops tests which ignore external VM flags
  • 43ad5d2: 8314063: The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection
  • 06756c4: 8288325: [windows] Actual and Preferred Size of AWT Non-resizable frame are different
  • 6398e46: 8273522: Rename test property vm.cds.archived.java.heap to vm.cds.write.archived.java.heap
  • ... and 21 more: https://git.openjdk.org/jdk17u-dev/compare/4636018f02f68ff4e0347969077bc80ed26ce847...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 22, 2023
@openjdk openjdk bot closed this Sep 22, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 22, 2023
@openjdk
Copy link

openjdk bot commented Sep 22, 2023

@shipilev Pushed as commit 93071dc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8316178-better-header-codeblobs branch December 11, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants

Comments