Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278185: Custom JRE cannot find non-ASCII named module inside #177

Closed
wants to merge 1 commit into from

Conversation

toshiona
Copy link

@toshiona toshiona commented Feb 24, 2022

I'd like to backport this to jdk17 since it fixes jlink issue with non-ASCII named module. Fix is low risk and applies cleanly. tier1 and tier2 tests have no regression with the patch.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8278185: Custom JRE cannot find non-ASCII named module inside

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/177/head:pull/177
$ git checkout pull/177

Update a local copy of the PR:
$ git checkout pull/177
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/177/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 177

View PR using the GUI difftool:
$ git pr show -t 177

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/177.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 24, 2022

👋 Welcome back tnakamura! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport fcd67a5242b7db06e4cb06b574972a463b209b2e 8278185: Custom JRE cannot find non-ASCII named module inside Feb 24, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Feb 24, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 24, 2022

@toshiona This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278185: Custom JRE cannot find non-ASCII named module inside

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 6650652: 8281460: Let ObjectMonitor have its own NMT category

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Feb 24, 2022
@toshiona toshiona marked this pull request as ready for review Feb 24, 2022
@openjdk openjdk bot added the rfr label Feb 24, 2022
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 24, 2022

Webrevs

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Feb 24, 2022

@toshiona, Please enable github actions for this repo.

@toshiona
Copy link
Author

@toshiona toshiona commented Feb 24, 2022

@GoeLin Thank you for teaching that. Enabled it. I hope my setting is correct.

@toshiona
Copy link
Author

@toshiona toshiona commented Feb 25, 2022

/integrate

@openjdk openjdk bot added the sponsor label Feb 25, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Feb 25, 2022

@toshiona
Your change (at version d4ab656) is now ready to be sponsored by a Committer.

@toshiona
Copy link
Author

@toshiona toshiona commented Feb 25, 2022

Got approval. May I ask someone sponsor this fix?

@phohensee
Copy link
Member

@phohensee phohensee commented Feb 25, 2022

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Feb 25, 2022

Going to push as commit df5a29c.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 6650652: 8281460: Let ObjectMonitor have its own NMT category

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Feb 25, 2022
@openjdk openjdk bot closed this Feb 25, 2022
@openjdk openjdk bot removed ready rfr sponsor labels Feb 25, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Feb 25, 2022

@phohensee @toshiona Pushed as commit df5a29c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@toshiona
Copy link
Author

@toshiona toshiona commented Feb 28, 2022

@phohensee Thank you for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
3 participants