-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8278185: Custom JRE cannot find non-ASCII named module inside #177
Conversation
👋 Welcome back tnakamura! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@toshiona This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
@toshiona, Please enable github actions for this repo. |
@GoeLin Thank you for teaching that. Enabled it. I hope my setting is correct. |
/integrate |
Got approval. May I ask someone sponsor this fix? |
/sponsor |
@phohensee @toshiona Pushed as commit df5a29c. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
@phohensee Thank you for your help! |
I'd like to backport this to jdk17 since it fixes jlink issue with non-ASCII named module. Fix is low risk and applies cleanly. tier1 and tier2 tests have no regression with the patch.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/177/head:pull/177
$ git checkout pull/177
Update a local copy of the PR:
$ git checkout pull/177
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/177/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 177
View PR using the GUI difftool:
$ git pr show -t 177
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/177.diff