Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8289584: (fs) Print size values in java/nio/file/FileStore/Basic.java when they differ by > 1GiB #1778

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Sep 22, 2023

I backport this for parity with 17.0.10-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8289584 needs maintainer approval

Issue

  • JDK-8289584: (fs) Print size values in java/nio/file/FileStore/Basic.java when they differ by > 1GiB (Sub-task - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1778/head:pull/1778
$ git checkout pull/1778

Update a local copy of the PR:
$ git checkout pull/1778
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1778/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1778

View PR using the GUI difftool:
$ git pr show -t 1778

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1778.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 22, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e291a67e96970d80a9915f8a23afffed6e0b8ded 8289584: (fs) Print size values in java/nio/file/FileStore/Basic.java when they differ by > 1GiB Sep 22, 2023
@openjdk
Copy link

openjdk bot commented Sep 22, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 22, 2023

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 22, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 22, 2023

Webrevs

@openjdk openjdk bot added the approval label Sep 24, 2023
@openjdk
Copy link

openjdk bot commented Sep 25, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289584: (fs) Print size values in java/nio/file/FileStore/Basic.java when they differ by > 1GiB

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 93211bd: 8293579: tools/jpackage/share/jdk/jpackage/tests/UnicodeArgsTest.java fails on Japanese Windows platform

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Sep 25, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Sep 25, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Sep 25, 2023

Going to push as commit 80d12cc.
Since your change was applied there have been 11 commits pushed to the master branch:

  • 04878e4: 8286969: Add a new test library API to execute kinit in SecurityTools.java
  • df411a8: 8285867: Convert applet manual tests SelectionVisible.java to Frame and automate
  • c70d9b0: 8286474: Drop --enable-preview from Sealed Classes related tests
  • 11639f7: 8202790: DnD test DisposeFrameOnDragTest.java does not clean up
  • ef0fc3e: 8271073: Improve testing with VM option VerifyArchivedFields
  • 1f86814: 8272551: mark hotspot runtime/modules tests which ignore external VM flags
  • 43240a8: 8272099: mark hotspot runtime/Monitor tests which ignore external VM flags
  • e96105a: 8271904: mark hotspot runtime/ClassFile tests which ignore external VM flags
  • d2f4ac1: 8271905: mark hotspot runtime/Metaspace tests which ignore external VM flags
  • 43f64d1: 8271893: mark hotspot runtime/PerfMemDestroy/PerfMemDestroy.java test as ignoring external VM flags
  • ... and 1 more: https://git.openjdk.org/jdk17u-dev/compare/d6eec8d4c07dc402a3e7abcfe372d23cbef596af...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 25, 2023
@openjdk openjdk bot closed this Sep 25, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 25, 2023
@openjdk
Copy link

openjdk bot commented Sep 25, 2023

@GoeLin Pushed as commit 80d12cc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant