Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272866: java.util.random package summary contains incorrect mixing function in table #178

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Feb 24, 2022

Backporting as it was dedicated for backport to earlier releases but then slipped through.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires a CSR request to be approved

Issues

  • JDK-8272866: java.util.random package summary contains incorrect mixing function in table
  • JDK-8272988: java.util.random package summary contains incorrect mixing function in table (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/178/head:pull/178
$ git checkout pull/178

Update a local copy of the PR:
$ git checkout pull/178
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/178/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 178

View PR using the GUI difftool:
$ git pr show -t 178

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/178.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 24, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e66c8afb59b57c4546656efa97f723f084964330 8272866: java.util.random package summary contains incorrect mixing function in table Feb 24, 2022
@openjdk
Copy link

openjdk bot commented Feb 24, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 24, 2022

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272866: java.util.random package summary contains incorrect mixing function in table

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 24, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 24, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Feb 28, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Feb 28, 2022

Going to push as commit 90d83a2.
Since your change was applied there have been 3 commits pushed to the master branch:

  • fc57ee6: 8272996: JNDI DNS provider fails to resolve SRV entries when IPV6 stack is enabled
  • df5a29c: 8278185: Custom JRE cannot find non-ASCII named module inside
  • 6650652: 8281460: Let ObjectMonitor have its own NMT category

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 28, 2022
@openjdk openjdk bot closed this Feb 28, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 28, 2022
@openjdk
Copy link

openjdk bot commented Feb 28, 2022

@GoeLin Pushed as commit 90d83a2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant