Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8286475: Drop --enable-preview from instanceof pattern matching related tests #1785

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Sep 25, 2023

I backport this for parity with 17.0.10-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8286475 needs maintainer approval

Issue

  • JDK-8286475: Drop --enable-preview from instanceof pattern matching related tests (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1785/head:pull/1785
$ git checkout pull/1785

Update a local copy of the PR:
$ git checkout pull/1785
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1785/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1785

View PR using the GUI difftool:
$ git pr show -t 1785

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1785.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 25, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8c977050aa20a7e9a6d0d83d18dce25defcc7a46 8286475: Drop --enable-preview from instanceof pattern matching related tests Sep 25, 2023
@openjdk
Copy link

openjdk bot commented Sep 25, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 25, 2023

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 25, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 25, 2023

Webrevs

@openjdk openjdk bot added the approval label Sep 26, 2023
@openjdk
Copy link

openjdk bot commented Sep 27, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286475: Drop --enable-preview from instanceof pattern matching related tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • 04d0906: 8311631: When multiple users run tools/jpackage/share/LicenseTest.java, Permission denied for writing /var/tmp/*.files
  • 52962e4: 8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with -XX:-VerifyDependencies
  • 1d618a3: 8271892: mark hotspot runtime/PrintStringTableStats/PrintStringTableStatsTest.java test as ignoring external VM flags
  • 2ac844b: 8292381: java/net/httpclient/SpecialHeadersTest.java fails with "ERROR: Shutting down connection: HTTP/2 client stopped"
  • 80d12cc: 8289584: (fs) Print size values in java/nio/file/FileStore/Basic.java when they differ by > 1GiB
  • 04878e4: 8286969: Add a new test library API to execute kinit in SecurityTools.java
  • df411a8: 8285867: Convert applet manual tests SelectionVisible.java to Frame and automate
  • c70d9b0: 8286474: Drop --enable-preview from Sealed Classes related tests
  • 11639f7: 8202790: DnD test DisposeFrameOnDragTest.java does not clean up
  • ef0fc3e: 8271073: Improve testing with VM option VerifyArchivedFields
  • ... and 5 more: https://git.openjdk.org/jdk17u-dev/compare/93211bd424cd86ccd0c9be0d838cc802764a1506...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Sep 27, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Sep 27, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Sep 27, 2023

Going to push as commit 6bdd611.
Since your change was applied there have been 22 commits pushed to the master branch:

  • 035b3f5: 8286473: Drop --enable-preview from Record related tests
  • cbdacc2: 8282011: test/jdk/tools/jpackage/windows/WinL10nTest.java test fails if light.exe is not in %PATH%
  • f79ed4d: 8281874: Can't unpack msi installers from test/jdk/tools/jpackage/windows/test/jdk/tools/jpackage/windows/WinShortcutPromptTest.java test
  • 4e6d34f: 8275440: Remove VirtualSpaceList::is_full()
  • 858c53b: 8274211: Test man page that options are documented
  • 919964a: 8272291: mark hotspot runtime/logging tests which ignore external VM flags
  • 084a797: 8272552: mark hotspot runtime/cds tests which ignore external VM flags
  • 04d0906: 8311631: When multiple users run tools/jpackage/share/LicenseTest.java, Permission denied for writing /var/tmp/*.files
  • 52962e4: 8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with -XX:-VerifyDependencies
  • 1d618a3: 8271892: mark hotspot runtime/PrintStringTableStats/PrintStringTableStatsTest.java test as ignoring external VM flags
  • ... and 12 more: https://git.openjdk.org/jdk17u-dev/compare/93211bd424cd86ccd0c9be0d838cc802764a1506...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 27, 2023
@openjdk openjdk bot closed this Sep 27, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 27, 2023
@openjdk
Copy link

openjdk bot commented Sep 27, 2023

@GoeLin Pushed as commit 6bdd611.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant