Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with -XX:-VerifyDependencies #1786

Closed

Conversation

roy-soumadipta
Copy link
Contributor

@roy-soumadipta roy-soumadipta commented Sep 25, 2023

Backporting the fix for https://bugs.openjdk.org/browse/JDK-8315770 merged as part of openjdk/jdk#15631. https://github.com/openjdk/jdk/commit/877731d2a20249ce4724a071ba2da1faa56daca4.patch apply failed due to differences in the file and the changes have been performed selectively.

Below are the test results:

  • after_release: 99.63s user 10.34s system 171% cpu 1:04.25 total
  • after_fastdebug: 433.45s user 17.35s system 401% cpu 1:52.15 total
  • before_release: 102.65s user 10.50s system 172% cpu 1:05.65 total
  • before_fastdebug: 516.82s user 16.68s system 253% cpu 3:30.51 total

Progress

  • JDK-8315770 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with -XX:-VerifyDependencies (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1786/head:pull/1786
$ git checkout pull/1786

Update a local copy of the PR:
$ git checkout pull/1786
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1786/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1786

View PR using the GUI difftool:
$ git pr show -t 1786

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1786.diff

Webrev

Link to Webrev Comment

Backporting the fix for https://bugs.openjdk.org/browse/JDK-8315770 merged as part of openjdk/jdk#15631. https://github.com/openjdk/jdk/commit/877731d2a20249ce4724a071ba2da1faa56daca4.patch apply failed due to differences in the file and the changes have been performed selectively.

Below are the test results:
* after_release: **99.63s user 10.34s system 171% cpu 1:04.25 total**
* after_fastdebug: **433.45s user 17.35s system 401% cpu 1:52.15 total**
* before_release: **102.65s user 10.50s system 172% cpu 1:05.65 total**
* before_fastdebug: **516.82s user 16.68s system 253% cpu 3:30.51 total**
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 25, 2023

👋 Welcome back roy-soumadipta! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 877731d2a20249ce4724a071ba2da1faa56daca4 8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with -XX:-VerifyDependencies Sep 25, 2023
@openjdk
Copy link

openjdk bot commented Sep 25, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 25, 2023

⚠️ @roy-soumadipta This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 25, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 25, 2023

Webrevs

@roy-soumadipta
Copy link
Contributor Author

/approval request Backport 877731d2a20249ce4724a071ba2da1faa56daca4 to JDK17u

@openjdk
Copy link

openjdk bot commented Sep 25, 2023

@roy-soumadipta The approval request has been created successfully.

@openjdk openjdk bot added the approval label Sep 25, 2023
@openjdk
Copy link

openjdk bot commented Sep 26, 2023

@roy-soumadipta This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with -XX:-VerifyDependencies

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 39 new commits pushed to the master branch:

  • 1d618a3: 8271892: mark hotspot runtime/PrintStringTableStats/PrintStringTableStatsTest.java test as ignoring external VM flags
  • 2ac844b: 8292381: java/net/httpclient/SpecialHeadersTest.java fails with "ERROR: Shutting down connection: HTTP/2 client stopped"
  • 80d12cc: 8289584: (fs) Print size values in java/nio/file/FileStore/Basic.java when they differ by > 1GiB
  • 04878e4: 8286969: Add a new test library API to execute kinit in SecurityTools.java
  • df411a8: 8285867: Convert applet manual tests SelectionVisible.java to Frame and automate
  • c70d9b0: 8286474: Drop --enable-preview from Sealed Classes related tests
  • 11639f7: 8202790: DnD test DisposeFrameOnDragTest.java does not clean up
  • ef0fc3e: 8271073: Improve testing with VM option VerifyArchivedFields
  • 1f86814: 8272551: mark hotspot runtime/modules tests which ignore external VM flags
  • 43240a8: 8272099: mark hotspot runtime/Monitor tests which ignore external VM flags
  • ... and 29 more: https://git.openjdk.org/jdk17u-dev/compare/1ce12c4f33d3d6905703d95df2574f4037dfd57d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Sep 26, 2023
@roy-soumadipta
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 26, 2023
@openjdk
Copy link

openjdk bot commented Sep 26, 2023

@roy-soumadipta
Your change (at version b6b769b) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 26, 2023

Going to push as commit 52962e4.
Since your change was applied there have been 39 commits pushed to the master branch:

  • 1d618a3: 8271892: mark hotspot runtime/PrintStringTableStats/PrintStringTableStatsTest.java test as ignoring external VM flags
  • 2ac844b: 8292381: java/net/httpclient/SpecialHeadersTest.java fails with "ERROR: Shutting down connection: HTTP/2 client stopped"
  • 80d12cc: 8289584: (fs) Print size values in java/nio/file/FileStore/Basic.java when they differ by > 1GiB
  • 04878e4: 8286969: Add a new test library API to execute kinit in SecurityTools.java
  • df411a8: 8285867: Convert applet manual tests SelectionVisible.java to Frame and automate
  • c70d9b0: 8286474: Drop --enable-preview from Sealed Classes related tests
  • 11639f7: 8202790: DnD test DisposeFrameOnDragTest.java does not clean up
  • ef0fc3e: 8271073: Improve testing with VM option VerifyArchivedFields
  • 1f86814: 8272551: mark hotspot runtime/modules tests which ignore external VM flags
  • 43240a8: 8272099: mark hotspot runtime/Monitor tests which ignore external VM flags
  • ... and 29 more: https://git.openjdk.org/jdk17u-dev/compare/1ce12c4f33d3d6905703d95df2574f4037dfd57d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 26, 2023
@openjdk openjdk bot closed this Sep 26, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 26, 2023
@openjdk
Copy link

openjdk bot commented Sep 26, 2023

@shipilev @roy-soumadipta Pushed as commit 52962e4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants