8293156: Dcmd VM.classloaders fails to print the full hierarchy#1804
8293156: Dcmd VM.classloaders fails to print the full hierarchy#1804GoeLin wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
73b1549 to
2f11d61
Compare
|
@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
|
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 6 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
Going to push as commit 1ce8f3e.
Your commit was automatically rebased without conflicts. |
A fix for the DCMD that prints classloaders.
I had to resolve because a comment differs in the context:
Line 202: // e.g. "+--- jdk.internal.reflect.DelegatingClassLoader"
Might be recognized a clean.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1804/head:pull/1804$ git checkout pull/1804Update a local copy of the PR:
$ git checkout pull/1804$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1804/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1804View PR using the GUI difftool:
$ git pr show -t 1804Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1804.diff
Webrev
Link to Webrev Comment