Skip to content

8293156: Dcmd VM.classloaders fails to print the full hierarchy#1804

Closed
GoeLin wants to merge 1 commit intoopenjdk:masterfrom
GoeLin:goetz_backport_8293156
Closed

8293156: Dcmd VM.classloaders fails to print the full hierarchy#1804
GoeLin wants to merge 1 commit intoopenjdk:masterfrom
GoeLin:goetz_backport_8293156

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Sep 27, 2023

A fix for the DCMD that prints classloaders.

I had to resolve because a comment differs in the context:
Line 202: // e.g. "+--- jdk.internal.reflect.DelegatingClassLoader"
Might be recognized a clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8293156 needs maintainer approval

Issue

  • JDK-8293156: Dcmd VM.classloaders fails to print the full hierarchy (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1804/head:pull/1804
$ git checkout pull/1804

Update a local copy of the PR:
$ git checkout pull/1804
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1804/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1804

View PR using the GUI difftool:
$ git pr show -t 1804

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1804.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 27, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c6be2cd347fc07dcc0da56acf40fc7a005119f09 8293156: Dcmd VM.classloaders fails to print the full hierarchy Sep 27, 2023
@openjdk
Copy link

openjdk bot commented Sep 27, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport Port of a pull request already in a different code base label Sep 27, 2023
@GoeLin GoeLin force-pushed the goetz_backport_8293156 branch from 73b1549 to 2f11d61 Compare September 27, 2023 14:23
@openjdk
Copy link

openjdk bot commented Sep 27, 2023

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk openjdk bot added the clean Identical backport; no merge resolution required label Sep 27, 2023
@openjdk
Copy link

openjdk bot commented Sep 27, 2023

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 27, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 27, 2023

Webrevs

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Sep 28, 2023
@openjdk
Copy link

openjdk bot commented Sep 28, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293156: Dcmd VM.classloaders fails to print the full hierarchy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 9404b2b: 8314121: test tools/jpackage/share/RuntimePackageTest.java#id0 fails on RHEL8
  • 486a468: 8307732: build-test-lib is broken
  • 0ce7d86: 8289745: JfrStructCopyFailed uses heap words instead of bytes for object sizes
  • 4ecf818: 8276054: JMH benchmarks for Fences
  • 8961594: 8300997: Add curl support to createJMHBundle.sh
  • e7fc89d: 8313322: RISC-V: implement MD5 intrinsic

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Sep 28, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Sep 28, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Sep 28, 2023

Going to push as commit 1ce8f3e.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 7e58a42: 8283670: gtest os.release_multi_mappings_vm is still racy
  • 9404b2b: 8314121: test tools/jpackage/share/RuntimePackageTest.java#id0 fails on RHEL8
  • 486a468: 8307732: build-test-lib is broken
  • 0ce7d86: 8289745: JfrStructCopyFailed uses heap words instead of bytes for object sizes
  • 4ecf818: 8276054: JMH benchmarks for Fences
  • 8961594: 8300997: Add curl support to createJMHBundle.sh
  • e7fc89d: 8313322: RISC-V: implement MD5 intrinsic

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 28, 2023
@openjdk openjdk bot closed this Sep 28, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 28, 2023
@openjdk
Copy link

openjdk bot commented Sep 28, 2023

@GoeLin Pushed as commit 1ce8f3e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8293156 branch September 28, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant