Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276141: XPathFactory set/getProperty method #181

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Feb 28, 2022

I backport this for parity with 17.0.3-oracle.

I adapted it as proposed in the backport CSR.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed
  • Change requires a CSR request to be approved

Issues

  • JDK-8276141: XPathFactory set/getProperty method
  • JDK-8276143: Add XPathFactory setProperty and getProperty methods (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/181/head:pull/181
$ git checkout pull/181

Update a local copy of the PR:
$ git checkout pull/181
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/181/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 181

View PR using the GUI difftool:
$ git pr show -t 181

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/181.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 28, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b226ab99c872e791d3ed9fca015cf92847904c34 8276141: XPathFactory set/getProperty method Feb 28, 2022
@openjdk
Copy link

openjdk bot commented Feb 28, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Feb 28, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 28, 2022

Webrevs

@phohensee
Copy link
Member

The patch is missing the changes to XPathFactory.java.

@openjdk
Copy link

openjdk bot commented Mar 1, 2022

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276141: XPathFactory set/getProperty method

Reviewed-by: mbaesken, phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 6ce19ed: 8282219: jdk/java/lang/ProcessBuilder/Basic.java fails on AIX
  • c2a62d7: 8279669: test/jdk/com/sun/jdi/TestScaffold.java uses wrong condition
  • 9e9c150: 8276841: Add support for Visual Studio 2022

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 1, 2022
Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed the CSR note. Lgtm.

@GoeLin
Copy link
Member Author

GoeLin commented Mar 1, 2022

The failing pre submit tests are timeouts of tests.

@GoeLin
Copy link
Member Author

GoeLin commented Mar 1, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Mar 1, 2022

Going to push as commit 51e7af2.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 8e13d2f: 8274471: Add support for RSASSA-PSS in OCSP Response
  • 6ce19ed: 8282219: jdk/java/lang/ProcessBuilder/Basic.java fails on AIX
  • c2a62d7: 8279669: test/jdk/com/sun/jdi/TestScaffold.java uses wrong condition
  • 9e9c150: 8276841: Add support for Visual Studio 2022

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 1, 2022
@openjdk openjdk bot closed this Mar 1, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 1, 2022
@openjdk
Copy link

openjdk bot commented Mar 1, 2022

@GoeLin Pushed as commit 51e7af2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8276141 branch March 1, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants