-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8276141: XPathFactory set/getProperty method #181
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
The patch is missing the changes to XPathFactory.java. |
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed the CSR note. Lgtm.
The failing pre submit tests are timeouts of tests. |
/integrate |
Going to push as commit 51e7af2.
Your commit was automatically rebased without conflicts. |
I backport this for parity with 17.0.3-oracle.
I adapted it as proposed in the backport CSR.
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/181/head:pull/181
$ git checkout pull/181
Update a local copy of the PR:
$ git checkout pull/181
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/181/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 181
View PR using the GUI difftool:
$ git pr show -t 181
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/181.diff