-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8295424: adjust timeout for another JLI GetObjectSizeIntrinsicsTest.java subtest #1816
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issues from the original commit. |
/clean |
@GoeLin This backport pull request is now marked as clean |
Hm, maybe you should remove the issue JDK-8297369? As you had to skip the patch to Fuzz.java for the reasons mentioned above, you should probably not mark JDK-8297369 as resolved... |
@GoeLin This pull request has not yet been marked as ready for integration. |
This is an interesting one. The two additional issues were added by Skara automagically as they are noted in the original change comment already. |
/issue remove JDK-8297369 |
@GoeLin |
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 12 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit ceafbb7.
Your commit was automatically rebased without conflicts. |
I backport this for parity with 17.0.10-oracle.
Skipped patch for Fuzz.java. That file is not in 17. It was introduced by 8284161: Implementation of Virtual Threads (Preview).
Will mark as clean.
Progress
Issues
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1816/head:pull/1816
$ git checkout pull/1816
Update a local copy of the PR:
$ git checkout pull/1816
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1816/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1816
View PR using the GUI difftool:
$ git pr show -t 1816
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1816.diff
Webrev
Link to Webrev Comment