Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8298298: NMT: count deltas are printed with 32-bit signed size #1824

Closed
wants to merge 8 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 3, 2023

A useful bugfix for NMT>

Trivial resolves in code.
The test that got extended by a few new cases is not in 17.
I added the test body so that the new test cases are checked.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8298298 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8298298: NMT: count deltas are printed with 32-bit signed size (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1824/head:pull/1824
$ git checkout pull/1824

Update a local copy of the PR:
$ git checkout pull/1824
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1824/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1824

View PR using the GUI difftool:
$ git pr show -t 1824

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1824.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 3, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into pr/1822 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f729f5b6d01b0d3a0ee21f50199ca30935c8237a 8298298: NMT: count deltas are printed with 32-bit signed size Oct 3, 2023
@openjdk
Copy link

openjdk bot commented Oct 3, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 3, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 3, 2023

Webrevs

Copy link

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
One minimal formatting request.
Thanks for the backport work.

src/hotspot/share/utilities/globalDefinitions.hpp Outdated Show resolved Hide resolved
Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

(looking guiltily at my feet)

...Thomas

@openjdk openjdk bot added approval and removed approval labels Oct 4, 2023
@GoeLin GoeLin changed the base branch from pr/1822 to master October 4, 2023 19:44
@openjdk
Copy link

openjdk bot commented Oct 4, 2023

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk
Copy link

openjdk bot commented Oct 4, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298298: NMT: count deltas are printed with 32-bit signed size

Reviewed-by: lucy, stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 4, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Oct 6, 2023

Thanks for implementing these in first place, Thomas!

@GoeLin
Copy link
Member Author

GoeLin commented Oct 6, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Oct 6, 2023

Going to push as commit 1cbcea2.
Since your change was applied there have been 5 commits pushed to the master branch:

  • bf2d133: 8301377: adjust timeout for JLI GetObjectSizeIntrinsicsTest.java subtest again
  • 60ae78a: 8298872: Update CheckStatus.java for changes to TLS implementation
  • 8ef142e: 8298874: Update TestAllSuites.java for TLS v1.2 and 1.3
  • 31422d7: 8316710: Exclude java/awt/font/Rotate/RotatedTextTest.java
  • f1c55d2: 8315937: Enable parallelism in vmTestbase/nsk/stress/numeric tests

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 6, 2023
@openjdk openjdk bot closed this Oct 6, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 6, 2023
@openjdk
Copy link

openjdk bot commented Oct 6, 2023

@GoeLin Pushed as commit 1cbcea2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8298298 branch October 6, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants